x
/
fuel-plugin-ldap-slaves
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(4 comments)

Patch-set: 5
Reviewer: Gerrit User 7745 <7745@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 7745 2016-10-06 10:14:05 +00:00 committed by Gerrit Code Review
parent 4a2ffe8290
commit 9d371e8bc9
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
aa5d7476ed310f5c38cacf9a2661abc12e5b3b3a Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"key": {
"uuid": "1a95cdbc_3d6e8b95",
"filename": "README.md",
"patchSetId": 5
},
"lineNbr": 2,
"author": {
"id": 7745
},
"writtenOn": "2016-10-06T10:14:05Z",
"side": 1,
"message": "alignment for \u003d",
"revId": "aa5d7476ed310f5c38cacf9a2661abc12e5b3b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a95cdbc_7d2d7345",
"filename": "deployment_scripts/puppet/manifests/ldap-slaves.pp",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 7745
},
"writtenOn": "2016-10-06T10:14:05Z",
"side": 1,
"message": "may be this paramter better to pass directly to class?",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 1,
"endChar": 51
},
"revId": "aa5d7476ed310f5c38cacf9a2661abc12e5b3b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a95cdbc_fdf98381",
"filename": "deployment_scripts/puppet/modules/ldap_slaves/manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 34,
"author": {
"id": 7745
},
"writtenOn": "2016-10-06T10:14:05Z",
"side": 1,
"message": "why do you need create this file from template, if it has own config provider? why not set all options via config provider?",
"range": {
"startLine": 29,
"startChar": 0,
"endLine": 34,
"endChar": 3
},
"revId": "aa5d7476ed310f5c38cacf9a2661abc12e5b3b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a95cdbc_bd9a9b61",
"filename": "deployment_scripts/puppet/modules/ldap_slaves/manifests/init.pp",
"patchSetId": 5
},
"lineNbr": 96,
"author": {
"id": 7745
},
"writtenOn": "2016-10-06T10:14:05Z",
"side": 1,
"message": "covered by 117 line",
"range": {
"startLine": 96,
"startChar": 0,
"endLine": 96,
"endChar": 54
},
"revId": "aa5d7476ed310f5c38cacf9a2661abc12e5b3b3a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}