x
/
fuel-plugin-solidfire-cinder
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
This commit is contained in:
Gerrit User 10221 2016-06-16 14:23:02 +00:00 committed by Gerrit Code Review
parent 2feb373b9b
commit e5c03a9b42
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
61a181ff07fe7bee96609fa6a923b0676c40a6e9
View File

@ -117,6 +117,30 @@
"revId": "61a181ff07fe7bee96609fa6a923b0676c40a6e9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_c80a2520",
"filename": "deployment_tasks.yaml",
"patchSetId": 3
},
"lineNbr": 12,
"author": {
"id": 10221
},
"writtenOn": "2016-06-16T14:23:02Z",
"side": 1,
"message": "Andrey, I have been looking at how you do it in the NTAP plugin, but my contention is you don\u0027t need the calls for group ceph-osd in the deployment_tasks, in the NTAP driver, since it is dependent on cinder only. You just stated that cinder-volume is always installed on the controller node when Ceph is the default, which means that we can setup the SolidFire and/or NetApp. SolidFire and/or NetApp do not require Ceph, but Ceph requires Cinder, so therefore we should just base the plugin on the Cinder role. The only difference between the 2 plugins is that SolidFire is not supporting SolidFire as the only backend (since Fuel always requires at least lvm or ceph anyways).",
"parentUuid": "7aa08908_31bd2d03",
"range": {
"startLine": 12,
"startChar": 0,
"endLine": 12,
"endChar": 22
},
"revId": "61a181ff07fe7bee96609fa6a923b0676c40a6e9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}