x
/
fuel-plugin-vxlan
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

some indentation should be corrected.
we should also  move from using fuel_settings to hiera in this commit for all parameters except the params related to ndoes (public, admin, mghmg and storage ip) as there is actually a bug on fuel fw (see related bug : https://bugs.launchpad.net/fuel/+bug/1476957)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 14030 2015-08-10 07:42:13 +00:00 committed by Gerrit Code Review
parent e3b6b73b6f
commit db4ccf62b8
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
34a0f6f020d424ff30b415a114599baedf568475 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "1a4dcd0f_4da9dcde",
"filename": "README.md",
"patchSetId": 1
},
"lineNbr": 63,
"author": {
"id": 14030
},
"writtenOn": "2015-08-10T07:42:13Z",
"side": 1,
"message": "white space in blank line should be avoid",
"revId": "34a0f6f020d424ff30b415a114599baedf568475",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a4dcd0f_4d80fc46",
"filename": "deployment_scripts/puppet/modules/vxlan/manifests/controller.pp",
"patchSetId": 1
},
"lineNbr": 51,
"author": {
"id": 14030
},
"writtenOn": "2015-08-10T07:42:13Z",
"side": 1,
"message": "white space at the end of lines should be avoid",
"revId": "34a0f6f020d424ff30b415a114599baedf568475",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a4dcd0f_2df25007",
"filename": "deployment_scripts/puppet/modules/vxlan/manifests/params.pp",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 14030
},
"writtenOn": "2015-08-10T07:42:13Z",
"side": 1,
"message": "mix between space and tabulation. use of tabulation should be avoid in the manifests",
"revId": "34a0f6f020d424ff30b415a114599baedf568475",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}