38 lines
1.7 KiB
Plaintext
38 lines
1.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_5b1c64c0",
|
|
"filename": "bindep.txt",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 3,
|
|
"author": {
|
|
"id": 2475
|
|
},
|
|
"writtenOn": "2019-09-24T09:20:40Z",
|
|
"side": 1,
|
|
"message": "I think Jenkins now requires Java 8, but it is not available in Ubuntu Trusty iirc.\n\nA few years ago I tried:\n\n* add bindep for java8 https://review.opendev.org/#/c/518284/\n* change the CI jobs to Xenial:\n** https://review.opendev.org/#/c/518287/\n** https://review.opendev.org/#/c/518333/\n\nAnd eventually gave up since I got lost with all the various dependencies/repositories involved.\n\nThen if the job pass fine just by adding openjdk-7-jdk, yeah I guess that is fine.",
|
|
"revId": "70b579cc6af5d82f533a7855c702c99ac94cf5a8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_bbceb82a",
|
|
"filename": "src/main/java/hudson/plugins/gearman/StartJobWorker.java",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 174,
|
|
"author": {
|
|
"id": 2475
|
|
},
|
|
"writtenOn": "2019-09-24T09:20:40Z",
|
|
"side": 1,
|
|
"message": "This block might need some comment to explain what is going?\n\nMy guess is that it adds the default values defined in the Jenkins job. But that seems to override the parameters that have been passed by the Gearman client?\n\nOr to say it otherwise, shouldn\u0027t the block you add be moved above the comment \"// decode the data from client\"?",
|
|
"revId": "70b579cc6af5d82f533a7855c702c99ac94cf5a8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |