From 85662d44c6aae7b01f6fe385195c0e83dc6b8d18 Mon Sep 17 00:00:00 2001 From: Akihiro Motoki Date: Wed, 25 Oct 2017 08:28:49 +0900 Subject: [PATCH] Fix queries using label:Code-Review<=2 Previously, label:Code-Review<=2 matches changes with some scores (+2, +1, -1, -2), so NOT label:Code-Review<=2 can be used to pick up changes without any reviews. After upgrading the gerrit, label:Code-Review<=2 now matches all changes including changes without reviews. As a result, NOT label:Code-Review<=2 excludes all changes and it is meaningless. This commit replaces 'NOT label:Code-Review<=2' with 'NOT label:Code-Review<=-1 NOT label:Code-Review>=1' to achieve the original purpose of queries. Also fixes meaningless label:Code-Review<=2 in some queries. Change-Id: I437963b9cf72d9b80420737ce8c5f066453cf803 --- dashboards/all-the-specs.dash | 2 +- dashboards/api-docs-impact.dash | 4 ++-- dashboards/api-wg.dash | 4 ++-- dashboards/app-catalog.dash | 2 +- dashboards/chef_watched.dash | 2 +- dashboards/cloud-init.dash | 2 +- dashboards/cross-project.dash | 4 ++-- dashboards/designate.dash | 2 +- dashboards/doc-program.dash | 4 ++-- dashboards/docsux.dash | 4 ++-- dashboards/fuel-ccp.dash | 2 +- dashboards/fuel-docs.dash | 4 ++-- dashboards/fuel-library.dash | 4 ++-- dashboards/fuel-logging-monitoring-alarming.dash | 2 +- dashboards/fuel-python.dash | 2 +- dashboards/fuel.dash | 4 ++-- dashboards/gate-changes.dash | 4 ++-- dashboards/glance.dash | 2 +- dashboards/heat.dash | 6 +++--- dashboards/horizon-related-repos.dash | 6 +++--- dashboards/horizon-stable.dash | 4 ++-- dashboards/horizon.dash | 6 +++--- dashboards/ironic-inspector.dash | 2 +- dashboards/ironic.dash | 2 +- dashboards/kolla.dash | 2 +- dashboards/magnum.dash | 6 +++--- dashboards/monasca.dash | 2 +- dashboards/murano.dash | 6 +++--- dashboards/networking-midonet.dash | 4 ++-- dashboards/neutron-subprojects-stable.dash | 4 ++-- dashboards/neutron-subprojects.dash | 4 ++-- dashboards/neutron.dash | 4 ++-- dashboards/new-contributors.dash | 4 ++-- dashboards/nova-api.dash | 2 +- dashboards/nova.dash | 4 ++-- dashboards/octavia.dash | 4 ++-- dashboards/openstack-ansible.dash | 5 ++--- dashboards/openstackclient.dash | 4 ++-- dashboards/oslo.dash | 4 ++-- dashboards/past-reviews.dash | 2 +- dashboards/patrole.dash | 4 ++-- dashboards/puppet-openstack.dash | 2 +- dashboards/qa-program.dash | 4 ++-- dashboards/requirements.dash | 4 ++-- dashboards/sahara.dash | 2 +- dashboards/solar.dash | 4 ++-- dashboards/stable.dash | 4 ++-- dashboards/starred.dash | 4 ++-- dashboards/swift.dash | 2 +- dashboards/tacker.dash | 8 ++++---- dashboards/tap-as-a-service.dash | 4 ++-- dashboards/telemetry.dash | 4 ++-- dashboards/tempest.dash | 4 ++-- dashboards/tooz_taskflow.dash | 4 ++-- dashboards/tripleo-quickstart.dash | 2 +- dashboards/tripleo-stable.dash | 2 +- dashboards/tripleo.dash | 2 +- dashboards/watched.dash | 4 ++-- dashboards/watcher.dash | 4 ++-- dashboards/zaqar.dash | 2 +- 60 files changed, 105 insertions(+), 106 deletions(-) diff --git a/dashboards/all-the-specs.dash b/dashboards/all-the-specs.dash index 898bddf..21ee74a 100644 --- a/dashboards/all-the-specs.dash +++ b/dashboards/all-the-specs.dash @@ -10,7 +10,7 @@ query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:se query = NOT label:Code-Review<=-1 limit:100 [section "Wayward Changes (Changes with no code review in the last 7 days)"] -query = NOT label:Code-Review<=2 age:7d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:7d [section "Some negative feedback, might still be worth commenting"] query = label:Code-Review=-1 NOT label:Code-Review=-2 limit:100 diff --git a/dashboards/api-docs-impact.dash b/dashboards/api-docs-impact.dash index 7a762f4..6f71f01 100644 --- a/dashboards/api-docs-impact.dash +++ b/dashboards/api-docs-impact.dash @@ -5,7 +5,7 @@ foreach = (project:openstack/api-site) status:open NOT owner:self NOT label:Work [section "Needs feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "API Docs"] query = (project:openstack/api-site) status:open @@ -14,4 +14,4 @@ query = (project:openstack/api-site) status:open query = (project:openstack/*) (status:open) AND (message:ApiImpact OR message:APIImpact) [section "You are a reviewer (but haven't voted in the current revision)"] -query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self \ No newline at end of file +query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self diff --git a/dashboards/api-wg.dash b/dashboards/api-wg.dash index 408b295..30dd7ee 100644 --- a/dashboards/api-wg.dash +++ b/dashboards/api-wg.dash @@ -16,10 +16,10 @@ query = label:Code-Review=+2 label:Code-Review=-1 query = label:Code-Review=+2 age:7d [section "Needs feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "All open reviews"] query = [section "You are a reviewer (but haven't voted in the current revision)"] -query = NOT label:Code-Review<=2,self reviewer:self NOT owner:self +query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT owner:self diff --git a/dashboards/app-catalog.dash b/dashboards/app-catalog.dash index 413f6fc..5f9d5ca 100644 --- a/dashboards/app-catalog.dash +++ b/dashboards/app-catalog.dash @@ -19,7 +19,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT query = NOT label:Workflow<=-1 NOT label:Verified<=-1,zuul NOT owner:self label:Code-Review-1 limit:20 branch:master [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d branch:master +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master [section "Work In Progress"] query = NOT label:Workflow>=1 NOT owner:self label:Workflow<=-1 limit:20 branch:master diff --git a/dashboards/chef_watched.dash b/dashboards/chef_watched.dash index 7dd8e27..59601f3 100644 --- a/dashboards/chef_watched.dash +++ b/dashboards/chef_watched.dash @@ -19,7 +19,7 @@ query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self limit:50 query = label:Verified<=-1,zuul NOT label:Code-Review<=-1 NOT label:Workflow<=-1 [section "5 Days Without Feedback"] -query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/openstack-chef-specs NOT label:Code-Review<=2 age:5d +query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/openstack-chef-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/openstack-chef-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/cloud-init.dash b/dashboards/cloud-init.dash index 05c8592..a28ff83 100644 --- a/dashboards/cloud-init.dash +++ b/dashboards/cloud-init.dash @@ -19,7 +19,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT query = NOT label:Workflow<=-1 NOT label:Verified<=-1,zuul NOT owner:self label:Code-Review-1 limit:20 branch:master [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d branch:master +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master [section "Work In Progress"] query = NOT label:Workflow>=1 NOT owner:self label:Workflow<=-1 limit:20 branch:master diff --git a/dashboards/cross-project.dash b/dashboards/cross-project.dash index cfaef44..d8d5acd 100644 --- a/dashboards/cross-project.dash +++ b/dashboards/cross-project.dash @@ -10,13 +10,13 @@ query = is:open NOT reviewedby:self NOT owner:self NOT label:Workflow=-1 query = is:open NOT label:Code-Review,self NOT owner:self label:Code-Review<=-1 NOT label:Workflow=-1 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d NOT label:Workflow=-1 +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d NOT label:Workflow=-1 [section "No Negative Core Feedback"] query = NOT label:Code-Review<=-1 NOT label:Workflow=-1 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d NOT label:Workflow=-1 +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d NOT label:Workflow=-1 [section "All Open Items"] query = is:open diff --git a/dashboards/designate.dash b/dashboards/designate.dash index 3dc2995..3550dac 100644 --- a/dashboards/designate.dash +++ b/dashboards/designate.dash @@ -20,7 +20,7 @@ query = label:Code-Review>=2 label:Verified>=1,zuul limit:50 NOT label:Workflow< query = label:Verified>=1,zuul label:Code-Review>=1 NOT label:Code-Review<=-1 limit:50 NOT label:Workflow<=-1 NOT owner:self NOT reviewedby:self [section "Passed Zuul, Need's Review"] -query = label:Verified>=1,zuul NOT label:Code-Review<=2 limit:50 NOT label:Workflow<=-1 NOT owner:self +query = label:Verified>=1,zuul NOT label:Code-Review<=-1 NOT label:Code-Review>=1 limit:50 NOT label:Workflow<=-1 NOT owner:self [section "My Open Reviews"] query = owner:self diff --git a/dashboards/doc-program.dash b/dashboards/doc-program.dash index 818d7b8..ce7727c 100644 --- a/dashboards/doc-program.dash +++ b/dashboards/doc-program.dash @@ -16,7 +16,7 @@ foreach = ( project:openstack/openstack-manuals OR NOT reviewedby:self [section "Needs feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Specs"] query = project:openstack/docs-specs status:open @@ -40,4 +40,4 @@ query = (project:openstack/openstack-manuals OR project:openstack/api-site OR pr query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last two days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/docsux.dash b/dashboards/docsux.dash index 8a84fa6..be29df4 100644 --- a/dashboards/docsux.dash +++ b/dashboards/docsux.dash @@ -4,7 +4,7 @@ description = Review Inbox for OpenStack Documentation foreach = (project:openstack/openstack-manuals OR project:openstack/security-doc OR openstack/openstack-ux status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self [section "Needs feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "User Docs"] query = (project:openstack/openstack-manuals OR project:openstack/security-doc) status:open @@ -19,4 +19,4 @@ query = (project:openstack/openstack-manuals OR project:openstack/api-site OR pr query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last two days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/fuel-ccp.dash b/dashboards/fuel-ccp.dash index dfe8324..6231db7 100644 --- a/dashboards/fuel-ccp.dash +++ b/dashboards/fuel-ccp.dash @@ -13,7 +13,7 @@ query = NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project query = NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-ccp-specs project:openstack/fuel-ccp-tests [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-ccp-specs NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-ccp-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Disagreement"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-ccp-specs label:Code-Review<=-1 label:Code-Review>=1 diff --git a/dashboards/fuel-docs.dash b/dashboards/fuel-docs.dash index f537e15..e99b619 100644 --- a/dashboards/fuel-docs.dash +++ b/dashboards/fuel-docs.dash @@ -10,10 +10,10 @@ query = owner:self (label:Verified<=-1 OR label:Workflow<=-1 OR label:Code-Revie query = NOT label:Verified<=-1 label:Code-Review>=1 NOT label:Workflow<=-1 NOT label:Code-Review<=-1 [section "5 days without feedback"] -query = age:5d NOT owner:self NOT label:Verified<=-1 NOT label:Workflow<=-1 NOT label:Code-Review<=2 +query = age:5d NOT owner:self NOT label:Verified<=-1 NOT label:Workflow<=-1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 [section "No negative feedback"] -query = NOT age:5d NOT owner:self NOT label:Verified<=-1 NOT label:Workflow<=-1 NOT label:Code-Review<=2 limit:50 +query = NOT age:5d NOT owner:self NOT label:Verified<=-1 NOT label:Workflow<=-1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 limit:50 [section "Other"] query = NOT owner:self NOT label:Verified<=-1 label:Code-Review-1 limit:20 diff --git a/dashboards/fuel-library.dash b/dashboards/fuel-library.dash index e02ed8e..90604fc 100644 --- a/dashboards/fuel-library.dash +++ b/dashboards/fuel-library.dash @@ -16,10 +16,10 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs label:Verified>=1 label:Code-Review>=1 NOT label:Code-Review>=2 NOT label:Code-Review<=-1 [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=2 NOT age:5d limit:50 +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT age:5d limit:50 [section "Disagreement"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs label:Code-Review<=-1 label:Code-Review>=1 diff --git a/dashboards/fuel-logging-monitoring-alarming.dash b/dashboards/fuel-logging-monitoring-alarming.dash index 5a7a890..da72ecd 100644 --- a/dashboards/fuel-logging-monitoring-alarming.dash +++ b/dashboards/fuel-logging-monitoring-alarming.dash @@ -10,7 +10,7 @@ query = owner:self (label:Verified-1 OR label:Code-Review-1 OR label:Workflow<=- query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 [section "2 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=2 age:2d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d [section "No Negative Feedback"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/fuel-python.dash b/dashboards/fuel-python.dash index 179393e..6d2fb81 100644 --- a/dashboards/fuel-python.dash +++ b/dashboards/fuel-python.dash @@ -33,7 +33,7 @@ query = NOT label:Verified<=-1 label:Code-Review>=2 NOT label:Code-Review<=-1 NO query = NOT label:Verified<=-1 label:Verified>=1 label:Code-Review>=1 NOT label:Code-Review>=2 NOT label:Code-Review<=-1 NOT label:Code-Review<=-2 NOT label:Workflow>=1 NOT label:Workflow<=-1 [section "New"] -query = NOT label:Verified<=-1 NOT label:Code-Review<=2 NOT age:2d limit:50 NOT label:Workflow>=1 NOT label:Workflow<=-1 +query = NOT label:Verified<=-1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT age:2d limit:50 NOT label:Workflow>=1 NOT label:Workflow<=-1 [section "Blocked"] query = label:Code-Review<=-2 diff --git a/dashboards/fuel.dash b/dashboards/fuel.dash index c391b79..8e1fbc3 100644 --- a/dashboards/fuel.dash +++ b/dashboards/fuel.dash @@ -16,10 +16,10 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs label:Verified>=1 label:Code-Review>=1 NOT label:Code-Review>=2 NOT label:Code-Review<=-1 [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=2 NOT age:5d limit:50 +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT age:5d limit:50 [section "Disagreement"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:openstack/fuel-specs label:Code-Review<=-1 label:Code-Review>=1 diff --git a/dashboards/gate-changes.dash b/dashboards/gate-changes.dash index 37d24e7..5bb318b 100644 --- a/dashboards/gate-changes.dash +++ b/dashboards/gate-changes.dash @@ -4,7 +4,7 @@ description = Review Inbox foreach = (project:openstack-infra/project-config OR project:openstack-infra/devstack-gate) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -16,4 +16,4 @@ query = label:Code-Review>=2 limit:50 query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/glance.dash b/dashboards/glance.dash index 665fcc2..bc54d58 100644 --- a/dashboards/glance.dash +++ b/dashboards/glance.dash @@ -25,7 +25,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1 NOT owner query = NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self label:Code-Review-1 limit:20 branch:master NOT reviewedby:self [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1 NOT owner:self NOT label:Code-Review<=2 age:5d branch:master NOT reviewedby:self +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1 NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master NOT reviewedby:self [section "Own Patches"] query = owner:self diff --git a/dashboards/heat.dash b/dashboards/heat.dash index 3d12761..c370552 100644 --- a/dashboards/heat.dash +++ b/dashboards/heat.dash @@ -10,16 +10,16 @@ query = owner:"OpenStack Proposal Bot " query = label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] -query = NOT label:Code-Review<=2,self reviewer:self +query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self [section "Passed Zuul, No Negative Feedback"] query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d [section "Negative Feedback"] query = label:Code-Review<=-1 limit:10 diff --git a/dashboards/horizon-related-repos.dash b/dashboards/horizon-related-repos.dash index 88ad30f..5049c36 100644 --- a/dashboards/horizon-related-repos.dash +++ b/dashboards/horizon-related-repos.dash @@ -25,16 +25,16 @@ query = is:starred query = NOT owner:self NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT label:Workflow<=-1 label:Verified>=1,zuul [section "Needs Approval"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 NOT label:Code-Review<=2,self +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self [section "Not Reviewed by Me"] -query = NOT owner:self NOT reviewer:self NOT label:Code-Review<=2,self limit:50 +query = NOT owner:self NOT reviewer:self NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self limit:50 [section "Needs Reverify"] query = label:Verified<=-1,zuul branch:master NOT label:Code-Review<=-1 NOT label:Workflow<=-1 [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/horizon-stable.dash b/dashboards/horizon-stable.dash index c9d08b3..f26cd67 100644 --- a/dashboards/horizon-stable.dash +++ b/dashboards/horizon-stable.dash @@ -5,7 +5,7 @@ foreach = (project:openstack/horizon OR project:openstack/django_openstack_auth) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self branch:^stable/.* [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Your are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -17,4 +17,4 @@ query = label:Code-Review>=2 NOT(reviewerin:horizon-core label:Code-Review<=-1) query = NOT label:Code-Review>=2 NOT(reviewerin:horizon-core label:Code-Review<=-1) limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/horizon.dash b/dashboards/horizon.dash index 191378d..1e1dc1e 100644 --- a/dashboards/horizon.dash +++ b/dashboards/horizon.dash @@ -14,16 +14,16 @@ query = is:starred query = NOT owner:self NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT label:Workflow<=-1 label:Verified>=1,zuul [section "Needs Approval"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 NOT label:Code-Review<=2,self +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self [section "Not Reviewed by Me"] -query = NOT owner:self NOT reviewer:self NOT label:Code-Review<=2,self limit:50 +query = NOT owner:self NOT reviewer:self NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self limit:50 [section "Needs Reverify"] query = label:Verified<=-1,zuul branch:master NOT label:Code-Review<=-1 NOT label:Workflow<=-1 [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/ironic-inspector.dash b/dashboards/ironic-inspector.dash index 157b447..361dd66 100644 --- a/dashboards/ironic-inspector.dash +++ b/dashboards/ironic-inspector.dash @@ -13,7 +13,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT query = label:Workflow>=1 NOT label:Workflow<=-1 label:Verified<=-1,zuul [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/ironic.dash b/dashboards/ironic.dash index 7dce222..bfd6ea3 100644 --- a/dashboards/ironic.dash +++ b/dashboards/ironic.dash @@ -19,7 +19,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT owner:self label:Code-R query = -age:1week limit:25 branch:master NOT label:Workflow>=1 (NOT label:Code-Review-1,ironic-core OR (label:Code-Review-1,ironic-python-agent-core AND project:openstack/ironic-python-agent) OR (label:Code-Review-1,ironic-inspector-core AND project:openstack/ironic-inspector)) label:Verified>=1,zuul NOT label:Code-Review>=2 NOT project:openstack/ironic-specs [section "Older (>1wk) Open Patches Passing Zuul Tests (limit 50)"] -query = age:1week limit:50 NOT label:Workflow>=1 NOT label:Code-Review<=2 age:1week NOT label:Verified>=1,zuul NOT project:openstack/ironic-specs (NOT label:Code-Review-1,ironic-core OR (label:Code-Review-1,ironic-python-agent-core AND project:openstack/ironic-python-agent) OR (label:Code-Review-1,ironic-inspector-core AND project:openstack/ironic-inspector)) +query = age:1week limit:50 NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:1week NOT label:Verified>=1,zuul NOT project:openstack/ironic-specs (NOT label:Code-Review-1,ironic-core OR (label:Code-Review-1,ironic-python-agent-core AND project:openstack/ironic-python-agent) OR (label:Code-Review-1,ironic-inspector-core AND project:openstack/ironic-inspector)) [section "Open Stable Backports"] query = NOT project:openstack/ironic-specs branch:^stable/.* status:open diff --git a/dashboards/kolla.dash b/dashboards/kolla.dash index 2a02983..7f2ed3b 100644 --- a/dashboards/kolla.dash +++ b/dashboards/kolla.dash @@ -12,7 +12,7 @@ query = owner:self (label:Verified-1,zuul OR label:Code-Review-1) query = label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 [section "5 Days Without Feedback"] -query = label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d +query = label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/magnum.dash b/dashboards/magnum.dash index d77fb3e..af11e93 100644 --- a/dashboards/magnum.dash +++ b/dashboards/magnum.dash @@ -10,16 +10,16 @@ query = owner:"OpenStack Proposal Bot " query = label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] -query = NOT label:Code-Review<=2,self reviewer:self +query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self [section "Passed Zuul, No Negative Feedback"] query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d [section "Negative Feedback"] query = label:Code-Review<=-1 limit:10 diff --git a/dashboards/monasca.dash b/dashboards/monasca.dash index 29b7980..84a689e 100644 --- a/dashboards/monasca.dash +++ b/dashboards/monasca.dash @@ -19,7 +19,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT query = NOT label:Workflow<=-1 NOT label:Verified<=-1,zuul NOT owner:self label:Code-Review-1 limit:20 branch:master [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d branch:master +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master [section "Work In Progress"] query = NOT label:Workflow>=1 NOT owner:self label:Workflow<=-1 limit:20 branch:master diff --git a/dashboards/murano.dash b/dashboards/murano.dash index 840eb08..c916447 100644 --- a/dashboards/murano.dash +++ b/dashboards/murano.dash @@ -7,10 +7,10 @@ foreach = (project:^.*/.*murano.* OR project:openstack/yaql) NOT label:Workflow< query = owner:self [section "You are a reviewer, but haven't voted in the current revision"] -query = NOT label:Code-Review<=2,self reviewer:self NOT owner:self +query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT owner:self [section "Need Feedback"] -query = NOT label:Code-Review<=2 NOT label:Verified<=-1 NOT owner:self +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT label:Verified<=-1 NOT owner:self [section "Passed Zuul, No Negative Feedback"] query = label:Code-Review>=1 NOT label:Code-Review<=-1 AND NOT label:Verified<=-1 NOT owner:self NOT reviewer:self limit:50 @@ -22,7 +22,7 @@ query = NOT owner:self NOT reviewer:self limit:25 query = label:Code-Review=1,self limit:25 [section "Need final +2"] -query = label:Code-Review>=2 NOT label:Code-Review<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=2,self NOT owner:self limit:25 +query = label:Code-Review>=2 NOT label:Code-Review<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self NOT owner:self limit:25 [section "My +2s"] query = label:Code-Review=2,self limit:25 diff --git a/dashboards/networking-midonet.dash b/dashboards/networking-midonet.dash index b6df8b2..b68105c 100644 --- a/dashboards/networking-midonet.dash +++ b/dashboards/networking-midonet.dash @@ -4,7 +4,7 @@ description = Review Inbox foreach = (project:openstack/networking-midonet) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d branch:master +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self branch:master @@ -16,7 +16,7 @@ query = label:Code-Review>=2 NOT(reviewerin:networking-midonet-core label:Code-R query = NOT label:Code-Review>=2 NOT(reviewerin:networking-midonet-core label:Code-Review<=-1) limit:50 branch:master [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d branch:master +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d branch:master [section "stable/ocata"] query = branch:stable/ocata diff --git a/dashboards/neutron-subprojects-stable.dash b/dashboards/neutron-subprojects-stable.dash index e3a48b1..801e113 100644 --- a/dashboards/neutron-subprojects-stable.dash +++ b/dashboards/neutron-subprojects-stable.dash @@ -16,7 +16,7 @@ foreach = ( project:openstack/python-neutronclient) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self branch:^stable/.* [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -28,4 +28,4 @@ query = label:Code-Review>=2 NOT(reviewerin:neutron-stable-maint label:Code-Revi query = NOT label:Code-Review>=2 NOT(reviewerin:neutron-stable-maint label:Code-Review<=-1) limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/neutron-subprojects.dash b/dashboards/neutron-subprojects.dash index f4bea30..dc5c5c8 100644 --- a/dashboards/neutron-subprojects.dash +++ b/dashboards/neutron-subprojects.dash @@ -13,7 +13,7 @@ foreach = ( project:openstack/ovsdbapp) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self branch:master [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -25,4 +25,4 @@ query = label:Code-Review>=2 NOT(reviewerin:neutron-core label:Code-Review<=-1) query = NOT label:Code-Review>=2 NOT(reviewerin:neutron-core label:Code-Review<=-1) limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/neutron.dash b/dashboards/neutron.dash index 8c59ca3..a307fac 100644 --- a/dashboards/neutron.dash +++ b/dashboards/neutron.dash @@ -8,7 +8,7 @@ foreach = (project:openstack/neutron OR status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self branch:master [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -20,4 +20,4 @@ query = label:Code-Review>=2 NOT(reviewerin:neutron-core label:Code-Review<=-1) query = NOT label:Code-Review>=2 NOT(reviewerin:neutron-core label:Code-Review<=-1) limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/new-contributors.dash b/dashboards/new-contributors.dash index efce576..8ab713f 100644 --- a/dashboards/new-contributors.dash +++ b/dashboards/new-contributors.dash @@ -7,7 +7,7 @@ foreach = reviewer:"Welcome, new contributor!" status:open NOT owner:self NOT la query = label:Verified<1,zuul [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d label:Verified>=1,zuul +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d label:Verified>=1,zuul [section "Needs final +2"] query = label:Code-Review>=2 limit:50 @@ -16,4 +16,4 @@ query = label:Code-Review>=2 limit:50 query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 label:Verified>=1,zuul limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d label:Verified>=1,zuul +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d label:Verified>=1,zuul diff --git a/dashboards/nova-api.dash b/dashboards/nova-api.dash index 8fc46b6..441ba49 100644 --- a/dashboards/nova-api.dash +++ b/dashboards/nova-api.dash @@ -13,7 +13,7 @@ query = topic:bp/remove-legacy-v2-api-code NOT reviewedby:self query = project:openstack/nova-specs NOT reviewedby:self [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Your are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self diff --git a/dashboards/nova.dash b/dashboards/nova.dash index 4672bde..ed7113a 100644 --- a/dashboards/nova.dash +++ b/dashboards/nova.dash @@ -23,10 +23,10 @@ query = (project:openstack/nova OR project:openstack/python-novaclient OR projec query = NOT label:Code-Review>=2,self NOT label:Code-Review<=-1,nova-core message:"bug: " limit:50 [section "Wayward Changes (Changes with no code review in the last two days)"] -query = NOT label:Code-Review<=2 age:2d limit:50 +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d limit:50 [section "Needs feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d limit:50 +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d limit:50 [section "Passed Zuul, No Negative Feedback"] query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 diff --git a/dashboards/octavia.dash b/dashboards/octavia.dash index dc8f2ca..a2815ac 100644 --- a/dashboards/octavia.dash +++ b/dashboards/octavia.dash @@ -13,10 +13,10 @@ query = label:Verified>=1,zuul label:Code-Review>=2 NOT(reviewerin:octavia-core query = label:Verified>=1,zuul NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT label:Workflow<=-1 label:Verified>=1,zuul limit:50 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = label:Verified>=1,zuul NOT label:Code-Review<=2 age:5d limit:10 +query = label:Verified>=1,zuul NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d limit:10 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = label:Verified>=1,zuul NOT label:Code-Review<=2 age:2d NOT label:Workflow<=-1 NOT reviewedby:self limit:10 +query = label:Verified>=1,zuul NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d NOT label:Workflow<=-1 NOT reviewedby:self limit:10 [section "Passed Zuul, No Negative Core Feedback"] query = label:Verified>=1,zuul NOT label:Workflow<=-1 NOT label:Code-Review>=2 NOT(reviewerin:octavia-core label:Code-Review<=-1) limit:10 diff --git a/dashboards/openstack-ansible.dash b/dashboards/openstack-ansible.dash index 82b6349..a434774 100644 --- a/dashboards/openstack-ansible.dash +++ b/dashboards/openstack-ansible.dash @@ -26,8 +26,7 @@ query = (starredby: a.settle@outlook.com OR label:Verified>=1,zuul [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d label:Verified>=1,zuul - +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d label:Verified>=1,zuul [section "You are a reviewer but haven't voted in the current revision"] query = reviewer:self NOT reviewedby:self label:Verified>=1,zuul @@ -39,7 +38,7 @@ query = label:Code-Review>=2 limit:50 NOT label:Code-Review<=-1 NOT reviewedby:s query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 label:Verified>=1,zuul [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d label:Verified>=1,zuul +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d label:Verified>=1,zuul [section "Failed Zuul, No Negative Feedback"] query = NOT label:Code-Review<=-1 label:Verified<=-1,zuul diff --git a/dashboards/openstackclient.dash b/dashboards/openstackclient.dash index 4538b7c..8f444e1 100644 --- a/dashboards/openstackclient.dash +++ b/dashboards/openstackclient.dash @@ -6,7 +6,7 @@ foreach = (project:openstack/python-openstackclient OR project:openstack/cliff) NOT reviewedby:self branch:master [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -21,4 +21,4 @@ query = NOT label:Code-Review<=-1 message:"bug: " query = NOT label:Code-Review<=-1 NOT message:"bug: " [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/oslo.dash b/dashboards/oslo.dash index c57fcc2..d2fafe4 100644 --- a/dashboards/oslo.dash +++ b/dashboards/oslo.dash @@ -30,7 +30,7 @@ query = topic:^bug/.* query = message:"Blueprint" [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = reviewer:self @@ -45,4 +45,4 @@ query = reviewer:10068 query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/past-reviews.dash b/dashboards/past-reviews.dash index 0b20ca1..63b93f1 100644 --- a/dashboards/past-reviews.dash +++ b/dashboards/past-reviews.dash @@ -4,7 +4,7 @@ description = Review Inbox foreach = status:open NOT owner:self reviewer:self [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Things I've -2ed"] query = label:Code-Review<=-2,self diff --git a/dashboards/patrole.dash b/dashboards/patrole.dash index 8227119..8887e3e 100644 --- a/dashboards/patrole.dash +++ b/dashboards/patrole.dash @@ -10,7 +10,7 @@ query = NOT label:Code-Review<=-1,patrole-core label:Code-Review>=2 NOT label:wo query = NOT label:Code-Review<=-1,patrole-core delta:<=10 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = reviewer:self @@ -22,4 +22,4 @@ query = NOT label:Code-Review<=-1,patrole-core message:"Closes-Bug: " query = NOT label:Code-Review<=-1,patrole-core NOT message:"Closes-Bug: " [section "Wayward Changes (Changes with no code review in the last 5 days)"] -query = label:Code-Review<=2 NOT label:Code-Review<=-1,patrole-core age:5d +query = NOT label:Code-Review>=1 NOT label:Code-Review<=-1,patrole-core age:5d diff --git a/dashboards/puppet-openstack.dash b/dashboards/puppet-openstack.dash index 03a51fa..2edab6e 100644 --- a/dashboards/puppet-openstack.dash +++ b/dashboards/puppet-openstack.dash @@ -18,7 +18,7 @@ query = label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Cod query = label:Verified<=-1,zuul NOT label:Code-Review<=-1 NOT label:Workflow<=-1 [section "5 Days Without Feedback"] -query = label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=2 age:5d +query = label:Verified>=1,zuul NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Disagreement"] query = label:Verified>=1,zuul label:Code-Review<=-1 label:Code-Review>=1 diff --git a/dashboards/qa-program.dash b/dashboards/qa-program.dash index d1b55c6..9163433 100644 --- a/dashboards/qa-program.dash +++ b/dashboards/qa-program.dash @@ -13,7 +13,7 @@ query = NOT label:Code-Review<=-1,tempest-core label:Code-Review>=2 query = NOT label:Code-Review<=-1,tempest-core delta:<=10 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -25,4 +25,4 @@ query = NOT label:Code-Review<=-1,tempest-core message:"Closes-Bug: " query = NOT label:Code-Review<=-1,tempest-core NOT message:"Closes-Bug: " [section "Wayward Changes (Changes with no code review in the last 5 days)"] -query = label:Code-Review<=2 NOT label:Code-Review<=-1,tempest-core age:5d +query = NOT label:Code-Review>=1 NOT label:Code-Review<=-1,tempest-core age:5d diff --git a/dashboards/requirements.dash b/dashboards/requirements.dash index f50170c..7765b40 100644 --- a/dashboards/requirements.dash +++ b/dashboards/requirements.dash @@ -7,7 +7,7 @@ foreach = project:openstack/requirements status:open NOT owner:self NOT label:Wo query = topic:new-release [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d branch:master +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -19,7 +19,7 @@ query = label:Code-Review>=2 limit:50 NOT reviewedby:self query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 branch:master [section "Wayward Changes (Changes with no code review in the last 2 days)"] -query = NOT label:Code-Review<=2 age:2d branch:master +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d branch:master [section "Stable Branch Changes"] query = branch:^stable/.* diff --git a/dashboards/sahara.dash b/dashboards/sahara.dash index 8b9aaaa..f0208c4 100644 --- a/dashboards/sahara.dash +++ b/dashboards/sahara.dash @@ -13,7 +13,7 @@ query = NOT owner:self project:openstack/sahara-specs query = label:Verified>=1,zuul label:Verified>=1,savanna-ci NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 NOT label:Workflow>=1 NOT label:Workflow<=-1 [section "5 Days Without Feedback"] -query = label:Verified>=1,zuul label:Verified>=1,savanna-ci NOT owner:self NOT project:openstack/sahara-specs NOT label:Code-Review<=2 NOT label:Workflow<=-1 age:5d +query = label:Verified>=1,zuul label:Verified>=1,savanna-ci NOT owner:self NOT project:openstack/sahara-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT label:Workflow<=-1 age:5d [section "New Contributors"] query = reviewer:"Welcome, new contributor!" diff --git a/dashboards/solar.dash b/dashboards/solar.dash index f5c44ec..8487d51 100644 --- a/dashboards/solar.dash +++ b/dashboards/solar.dash @@ -13,10 +13,10 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 label:Verified>=1 label:Code-Review>=1 NOT label:Code-Review>=2 NOT label:Code-Review<=-1 [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=2 NOT age:5d limit:50 +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT age:5d limit:50 [section "Disagreement"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 label:Code-Review<=-1 label:Code-Review>=1 diff --git a/dashboards/stable.dash b/dashboards/stable.dash index c590c71..e476f48 100644 --- a/dashboards/stable.dash +++ b/dashboards/stable.dash @@ -4,7 +4,7 @@ description = Review Inbox foreach = (project:openstack/ceilometer OR project:openstack/python-ceilometerclient OR project:openstack/cinder OR project:openstack/python-cinderclient OR project:openstack/glance OR project:openstack/python-glanceclient OR project:openstack/heat OR project:openstack/python-heatclient OR project:openstack/horizon OR project:openstack/keystone OR project:openstack/python-keystoneclient OR project:openstack/neutron OR project:openstack/python-neutronclient OR project:openstack/nova OR project:openstack/python-novaclient OR project:openstack/trove OR project:openstack/python-troveclient) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self branch:^stable/.* [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -16,4 +16,4 @@ query = label:Code-Review>=2 NOT(reviewerin:stable-maint-core label:Code-Review< query = NOT label:Code-Review>=2 NOT(reviewerin:stable-maint-core label:Code-Review<=-1) limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/starred.dash b/dashboards/starred.dash index a3b7456..ef7d1c6 100644 --- a/dashboards/starred.dash +++ b/dashboards/starred.dash @@ -20,7 +20,7 @@ query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 query = label:Code-Review>=2 limit:50 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/swift.dash b/dashboards/swift.dash index 19368b2..60214dc 100644 --- a/dashboards/swift.dash +++ b/dashboards/swift.dash @@ -22,7 +22,7 @@ query = NOT project:openstack/swift-specs branch:^feature/.* status:open query = NOT label:Workflow>=1 (NOT label:Code-Review-1,swift-core OR (label:Code-Review-1,swiftclient-core AND project:openstack/python-swiftclient)) label:Verified>=1,zuul NOT label:Code-Review>=2 NOT project:openstack/swift-specs -age:1week branch:master [section "Older open patches"] -query = NOT label:Workflow>=1 NOT label:Code-Review<=2 age:1week NOT project:openstack/swift-specs (NOT label:Code-Review-1,swift-core OR (label:Code-Review-1,swiftclient-core AND project:openstack/python-swiftclient)) +query = NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:1week NOT project:openstack/swift-specs (NOT label:Code-Review-1,swift-core OR (label:Code-Review-1,swiftclient-core AND project:openstack/python-swiftclient)) [section "Swift Specs"] query = project:openstack/swift-specs NOT label:Code-Review<=-2 diff --git a/dashboards/tacker.dash b/dashboards/tacker.dash index 231126d..3083f80 100644 --- a/dashboards/tacker.dash +++ b/dashboards/tacker.dash @@ -7,13 +7,13 @@ foreach = (project:^.*/.*tacker.*) NOT label:Workflow<=-1 NOT label:Code-Review< query = owner:"OpenStack Proposal Bot " [section "Needs final +2"] -query = label:Code-Review>=2 NOT label:Code-Review<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=2,self NOT owner:self limit:10 +query = label:Code-Review>=2 NOT label:Code-Review<=-1 NOT label:Verified<=-1 NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self NOT owner:self limit:10 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 NOT label:Verified<=-1 NOT owner:self age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT label:Verified<=-1 NOT owner:self age:5d [section "You are a reviewer, but haven't voted in the current revision"] -query = NOT label:Code-Review<=2,self reviewer:self NOT owner:self limit:10 +query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT owner:self limit:10 [section "Passed Zuul, No Negative Feedback"] query = label:Code-Review>=1 NOT label:Code-Review<=-1 AND NOT label:Verified<=-1 NOT owner:self NOT reviewer:self limit:10 @@ -25,5 +25,5 @@ query = label:Code-Review<=-1 limit:10 query = NOT owner:self NOT reviewer:self limit:10 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/tap-as-a-service.dash b/dashboards/tap-as-a-service.dash index 63a13f7..6fc1bf4 100644 --- a/dashboards/tap-as-a-service.dash +++ b/dashboards/tap-as-a-service.dash @@ -4,7 +4,7 @@ description = Review Inbox foreach = (project:openstack/tap-as-a-service OR project:openstack/tap-as-a-service-dashboard) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,zuul NOT reviewedby:self [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d branch:master +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self branch:master @@ -16,7 +16,7 @@ query = label:Code-Review>=2 NOT(reviewerin:tap-as-a-service-core label:Code-Rev query = NOT label:Code-Review>=2 NOT(reviewerin:tap-as-a-service-core label:Code-Review<=-1) limit:50 branch:master [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d branch:master +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d branch:master [section "stable/ocata"] query = branch:stable/ocata diff --git a/dashboards/telemetry.dash b/dashboards/telemetry.dash index 9cfa2b4..ba29e5d 100644 --- a/dashboards/telemetry.dash +++ b/dashboards/telemetry.dash @@ -16,7 +16,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT query = label:Workflow>=1 NOT label:Workflow<=-1 label:Verified<=-1,zuul [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT project:openstack/ceilometer-specs NOT label:Code-Review<=2 age:5d +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT project:openstack/ceilometer-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback (top 50)"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT owner:self NOT project:openstack/ceilometer-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 @@ -25,7 +25,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,zuul NOT query = NOT label:Workflow<=-1 NOT label:Verified<=-1,zuul NOT owner:self NOT project:openstack/ceilometer-specs label:Code-Review-1 limit:20 [section "Unreviewed, not WIP (top 20)"] -query = NOT label:Code-Review<=2 NOT label:Workflow<=-1 NOT project:openstack/ceilometer-specs limit:20 +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT label:Workflow<=-1 NOT project:openstack/ceilometer-specs limit:20 [section "Work In Progress Or Unverified (top 20)"] query = NOT label:Workflow>=1 NOT owner:self (label:Workflow<=-1 OR label:Verified<=-1,zuul) limit:20 diff --git a/dashboards/tempest.dash b/dashboards/tempest.dash index d1a0552..dac8ca6 100644 --- a/dashboards/tempest.dash +++ b/dashboards/tempest.dash @@ -7,7 +7,7 @@ foreach = (project:openstack/tempest OR project:openstack/tempest-lib OR project query = project:openstack/qa-specs [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -19,4 +19,4 @@ query = (project:openstack/tempest OR project:openstack-dev/grenade) label:Code- query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/tooz_taskflow.dash b/dashboards/tooz_taskflow.dash index 4dc8edb..3972f1f 100644 --- a/dashboards/tooz_taskflow.dash +++ b/dashboards/tooz_taskflow.dash @@ -4,7 +4,7 @@ description = Review Inbox foreach = (project:openstack/taskflow OR project:openstack/tooz) status:open NOT label:Workflow<=-1 label:Verified>=1,zuul NOT label:Code-Review>=-2 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -19,4 +19,4 @@ query = NOT label:Code-Review<=-1 message:"bug: " query = NOT label:Code-Review<=-1 NOT message:"bug: " [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/tripleo-quickstart.dash b/dashboards/tripleo-quickstart.dash index 15508fb..6f54c2f 100644 --- a/dashboards/tripleo-quickstart.dash +++ b/dashboards/tripleo-quickstart.dash @@ -14,7 +14,7 @@ query = NOT owner:self project:openstack/tripleo-specs query = label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 [section "5 Days Without Feedback"] -query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=2 age:5d +query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/tripleo-stable.dash b/dashboards/tripleo-stable.dash index e2bfa8b..6fdbc4e 100644 --- a/dashboards/tripleo-stable.dash +++ b/dashboards/tripleo-stable.dash @@ -19,7 +19,7 @@ query = NOT owner:self project:openstack/tripleo-specs query = label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 [section "5 Days Without Feedback"] -query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=2 age:5d +query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/tripleo.dash b/dashboards/tripleo.dash index 03705cb..a750014 100644 --- a/dashboards/tripleo.dash +++ b/dashboards/tripleo.dash @@ -33,7 +33,7 @@ query = NOT owner:self project:openstack/tripleo-specs query = label:Verified>=1,zuul NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 [section "5 Days Without Feedback"] -query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=2 age:5d +query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "No Negative Feedback"] query = label:Verified>=1,zuul NOT owner:self NOT project:openstack/tripleo-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 diff --git a/dashboards/watched.dash b/dashboards/watched.dash index c25e2f7..8c2ba06 100644 --- a/dashboards/watched.dash +++ b/dashboards/watched.dash @@ -13,7 +13,7 @@ query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 query = label:Code-Review>=2 limit:50 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "Wayward Changes (Changes with no code review in the last 2days)"] -query = NOT label:Code-Review<=2 age:2d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:2d diff --git a/dashboards/watcher.dash b/dashboards/watcher.dash index 580e394..9deaa8a 100644 --- a/dashboards/watcher.dash +++ b/dashboards/watcher.dash @@ -14,7 +14,7 @@ query = NOT label:Code-Review<=-1 label:Code-Review>=2 NOT label:workflow>=1 query = NOT label:Code-Review<=-1 delta:<=10 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] -query = NOT label:Code-Review<=2 age:5d +query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d [section "You are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self @@ -26,4 +26,4 @@ query = NOT label:Code-Review<=-1 message:"Closes-Bug: " query = NOT label:Code-Review<=-1 NOT message:"Closes-Bug: " [section "Wayward Changes (Changes with no code review in the last 5 days)"] -query = label:Code-Review<=2 NOT label:Code-Review<=-1 age:5d +query = NOT label:Code-Review>=1 NOT label:Code-Review<=-1 age:5d diff --git a/dashboards/zaqar.dash b/dashboards/zaqar.dash index 495dd07..7ae51c1 100644 --- a/dashboards/zaqar.dash +++ b/dashboards/zaqar.dash @@ -25,7 +25,7 @@ query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1 NOT owner query = NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self label:Code-Review-1 limit:20 branch:master [section "5 Days Without Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1 NOT owner:self NOT label:Code-Review<=2 age:5d branch:master +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1 NOT owner:self NOT label:Code-Review<=-1 NOT label:Code-Review>=1 age:5d branch:master [section "Own Patches"] query = owner:self