x
/
group-based-policy-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(3 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 18031 2017-04-28 19:58:42 +00:00 committed by Gerrit Code Review
parent 7748df6db5
commit 10eba59df0
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
c200c8997fcb05b817902c6c70a69c0b11152a04
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_c78b8dc0",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 153,
"author": {
"id": 18031
},
"writtenOn": "2017-04-28T19:58:42Z",
"side": 1,
"message": "Good point -- will change.",
"parentUuid": "5ff73747_c42a6bd9",
"range": {
"startLine": 152,
"startChar": 58,
"endLine": 153,
"endChar": 49
},
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_c7d38d03",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_b80b0028",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 273,
"author": {
"id": 18031
},
"writtenOn": "2017-04-28T19:58:42Z",
"side": 1,
"message": "You\u0027re correct about the JSON checking -- I tried with just string and it didn\u0027t work. However, I was able to make the UTs work with this:\n\n \u0027ip_pool\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,\n \u0027convert_to\u0027: conv.convert_to_list,\n \u0027validate\u0027: {\u0027type:subnet_list\u0027: None},\n \u0027default\u0027: \u002710.0.0.0/8\u0027, \u0027is_visible\u0027: True},\n\nNote the convert_to_list, and the type of subnet_list.\n\nI will do some more investigation on the String(64) limitation, to see if I can come up with a preference or other option.",
"parentUuid": "5ff73747_c7d38d03",
"range": {
"startLine": 273,
"startChar": 34,
"endLine": 273,
"endChar": 45
},
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_04e9737e",
@ -68,6 +116,30 @@
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_53029f0b",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 278,
"author": {
"id": 18031
},
"writtenOn": "2017-04-28T19:58:42Z",
"side": 1,
"message": "sounds good -- will change.",
"parentUuid": "5ff73747_04e9737e",
"range": {
"startLine": 278,
"startChar": 33,
"endLine": 278,
"endChar": 69
},
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}