Update patch set 7
Patch Set 7: (11 comments) Thanks for the review Sumit! I'll submit an update with these fixes, along with some changes that I realized we'll need for the proxy ip_pool parameter. I still have work to do on the external segments as well. Patch-set: 7
This commit is contained in:
Gerrit User 18031
Gerrit Code Review
parent
c0c9379bcc
commit
370852f718
|
|
@ -17,6 +17,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_eaf34272",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 48,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "That\u0027s a good question. Bob had an idea that the above default would be used if there weren\u0027t default subnetpools configured, and the user hadn\u0027t provided any form of prefix (e.g. via ip_pool, subnetpool IDs, etc.). However, this would no longer be defined in the RESOURCE_ATTRIBUTE_MAP, but would instead be defined as a hard-coded value. We could of course add a configuration file parameter for this, or just use the one from the implicit policy mapping driver. I\u0027m open to ideas on this.",
|
||||
"parentUuid": "3f044301_e31caf6b",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_c33093eb",
|
||||
|
|
@ -34,6 +52,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_caeac673",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 66,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Good point -- will add.",
|
||||
"parentUuid": "3f044301_c33093eb",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_ed6380db",
|
||||
|
|
@ -51,6 +87,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_8a04be4b",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 69,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Good point - the code fails if it\u0027s 31 as well, or if it\u0027s less than 2. I\u0027ll add that text here.",
|
||||
"parentUuid": "3f044301_ed6380db",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_839e0bb6",
|
||||
|
|
@ -74,6 +128,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_ea98e21b",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 71,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Sure - will change.",
|
||||
"parentUuid": "3f044301_839e0bb6",
|
||||
"range": {
|
||||
"startLine": 71,
|
||||
"startChar": 0,
|
||||
"endLine": 71,
|
||||
"endChar": 71
|
||||
},
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_c3b3f34c",
|
||||
|
|
@ -91,6 +169,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_ca9f6601",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 80,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Good call. Will change.",
|
||||
"parentUuid": "3f044301_c3b3f34c",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_637e5f6c",
|
||||
|
|
@ -108,6 +204,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_6a84d2b1",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 83,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Good addition. Will fix.",
|
||||
"parentUuid": "3f044301_637e5f6c",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_83c16be7",
|
||||
|
|
@ -125,6 +239,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_4a9356fb",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 104,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Will add. Thanks!",
|
||||
"parentUuid": "3f044301_83c16be7",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_a61475a1",
|
||||
|
|
@ -142,6 +274,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_2a8ecacf",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 125,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Will add.",
|
||||
"parentUuid": "3f044301_a61475a1",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_a6c7d512",
|
||||
|
|
@ -159,6 +309,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_0abf8e61",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 195,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Will add -- thanks!",
|
||||
"parentUuid": "3f044301_a6c7d512",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_663b0deb",
|
||||
|
|
@ -176,6 +344,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_eac102e6",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 358,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "None yet -- I haven\u0027t done anything with external segments yet, other than copy the definition. Sorry for the confusion!",
|
||||
"parentUuid": "3f044301_663b0deb",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_a631150e",
|
||||
|
|
@ -192,6 +378,24 @@
|
|||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f044301_aabbfa6f",
|
||||
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 427,
|
||||
"author": {
|
||||
"id": 18031
|
||||
},
|
||||
"writtenOn": "2017-05-09T17:33:26Z",
|
||||
"side": 1,
|
||||
"message": "Good point, and evidenced that I haven\u0027t had to change the python-client for my testing. Will remove.",
|
||||
"parentUuid": "3f044301_a631150e",
|
||||
"revId": "40c76f13cc12b28bc82e4419064b822615a73d9d",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue