Update patch set 5

Patch Set 5:

(1 comment)

Thanks Thomas for your effort so far and apologies for the piecemeal comments. Are we also planning to extend this to include the external_segment?

Patch-set: 5
This commit is contained in:
Gerrit User 490 2017-05-01 22:30:28 +00:00 committed by Gerrit Code Review
parent a1247aaf28
commit 9dec7cfb00
1 changed files with 24 additions and 0 deletions

View File

@ -381,6 +381,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_d7743a00",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 273,
"author": {
"id": 490
},
"writtenOn": "2017-05-01T22:30:28Z",
"side": 1,
"message": "I prefer the option of not adding an extra attribute, but overloading the current ip_pool to be set to a comma-separated list of CIDRs that can be validated individually, then converted to a list and processed subsequently. \n\nI also like Bob\u0027s suggestion to do away with persisting the ip_pool value and instead constructing it every time its queried.",
"parentUuid": "5ff73747_12bbe7c4",
"range": {
"startLine": 273,
"startChar": 34,
"endLine": 273,
"endChar": 45
},
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_04e9737e",