Update patch set 5

Patch Set 5:

(2 comments)

Patch-set: 5

c200c8997fcb05b817902c6c70a69c0b11152a04

@@ -23,6 +23,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "5ff73747_1792a357",
+        "filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
+        "patchSetId": 5
+      },
+      "lineNbr": 55,
+      "author": {
+        "id": 18031
+      },
+      "writtenOn": "2017-05-01T21:24:33Z",
+      "side": 1,
+      "message": "Good point. I add text to qualify that this feature can only be used when the ml2plus plugin is used. Note that the existing implicit workflow still is supported (i.e. where the subnetpools and address scopes get created).",
+      "parentUuid": "5ff73747_f78f3772",
+      "range": {
+        "startLine": 54,
+        "startChar": 0,
+        "endLine": 55,
+        "endChar": 56
+      },
+      "revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_3c06a453",
@@ -46,6 +70,30 @@
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
     },
+    {
+      "key": {
+        "uuid": "5ff73747_97e233d4",
+        "filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
+        "patchSetId": 5
+      },
+      "lineNbr": 70,
+      "author": {
+        "id": 18031
+      },
+      "writtenOn": "2017-05-01T21:24:33Z",
+      "side": 1,
+      "message": "Yeah -- I\u0027ve run into some of this with the UTs. In the case where it\u0027s None, and we\u0027re creating the implicit pool, it should be some default, and possibly/preferably. I saw that the implicit policy driver has a config file default for this:\n\nhttps://github.com/openstack/group-based-policy/blob/master/gbpservice/neutron/services/grouppolicy/drivers/implicit_policy.py#L45-L49\n\nHowever, there isn\u0027t a similar configurable default for the resource mapping driver. I can add one if that makes sense to folks.",
+      "parentUuid": "5ff73747_3c06a453",
+      "range": {
+        "startLine": 68,
+        "startChar": 0,
+        "endLine": 70,
+        "endChar": 72
+      },
+      "revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "5ff73747_c42a6bd9",