From b0768525ebf314719248bcd269355c8105770003 Mon Sep 17 00:00:00 2001 From: ank Date: Thu, 11 Aug 2016 00:17:47 +0530 Subject: [PATCH] Separate Set and Edit IP links from group name As part of #1609363, links was added to associate fixed IP while creating member for each group. As part of this bug, sepated IP address association links from group name as mentioned below To set IP address : [Click to Set IP] To edit associated IP: [, Click to Edit IP] Change-Id: Ia51224aeb23559dd2ff6d0faa3cf5c6b9d4e3097 Closes-Bug: #1611908 (cherry picked from commit ebd860e5ec73bb804f09a7988ad0e9cfbf0ccdca) --- gbpui/static/dashboard/js/member.js | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/gbpui/static/dashboard/js/member.js b/gbpui/static/dashboard/js/member.js index fbc6993..4c490ae 100644 --- a/gbpui/static/dashboard/js/member.js +++ b/gbpui/static/dashboard/js/member.js @@ -42,9 +42,9 @@ member = { **/ generate_group_element: function(name, id, value, selected) { var $li = $('
  • '); - ip_lable = '' + ip_lable = '' if (selected){ - ip_lable = ' Set IP Address' + ip_lable = " [Click to Set IP]" } $li.attr('name', value).html(name + ip_lable + ''); return $li; @@ -73,9 +73,9 @@ member = { }); groupListId.find("input:checkbox").removeAttr('checked'); active_groups.each(function(index, value){ - ip_ele = $("#selected_network li[name^='"+ value +"'] strong") + ip_ele = $("#selected_network li[name^='"+ value +"'] span") if(ip_ele.text() == "" && $("#id_count").val() == 1){ - ip_ele.html(" Set IP Address") + ip_ele.html(" [Click to Set IP]") } groupListId.find("input:checkbox[value^='" + value + "']") .prop('checked', true) @@ -113,7 +113,7 @@ member = { $this.parent().appendTo(selected_group); } else if ($this.parents("ul#selected_network").length > 0) { $this.parent().appendTo(available_group); - $this.parent().find("strong").html(""); + $this.parent().find("span").html(""); } updateForm(); }); @@ -160,7 +160,7 @@ member = { selected_element = $(".multiple-checkbox #id_network li input[value^='"+ ptg +"']"); value = selected_element.val(); values = value.split(':'); - group = $(selected_group).clone().find('strong').remove().end().text(); + group = $(selected_group).clone().find('span').remove().end().text(); $("#group").text(group); subnets = values[1].split(";") $('#subnets_table tbody').empty(); @@ -206,7 +206,8 @@ member = { selected_element = $(".multiple-checkbox #id_network li input[value^='"+ ptg +"']"); selected_element.val(value) if(fixed_ip){ - $("#selected_network li[name^='"+ ptg +"'] strong").html(" ( "+fixed_ip +") Edit IP") + $("#selected_network li[name^='"+ ptg +"'] span").html( + " ["+fixed_ip + ", Click to Edit IP]") } $("ul#selected_network li[name^='"+ ptg +"']").css("background-color", ""); $("#fixed_ip_div").hide() @@ -229,7 +230,7 @@ member = { value = ptg + ":" + subnet selected_element = $(".multiple-checkbox #id_network li input[value^='"+ ptg +"']"); selected_element.val(value) - $("#selected_network li[name^='"+ ptg +"'] strong").html(" Set IP Address") + $("#selected_network li[name^='"+ ptg +"'] span").html(" [Click to Set IP]") $("#fixed_ip_div").hide() $("ul#selected_network li").css("background-color", ""); member.control_max_instances() @@ -257,10 +258,10 @@ member = { help.attr("title", title) $(document).on('input', '#id_count',function(){ if($("#id_count").val() > 1){ - $("#selected_network li").find("strong").html(""); + $("#selected_network li").find("span").html(""); } else{ - $("#selected_network li").find("strong").html(" Set IP Address") + $("#selected_network li").find("span").html(" [Click to Set IP]") $("#errors").hide().text("") } $("#fixed_ip_div").hide()