x
/
horizon-mellanox
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Label: Code-Review=-1
This commit is contained in:
Gerrit User 12171 2016-05-16 12:33:49 +00:00 committed by Gerrit Code Review
parent 10f613117a
commit 00989d94ff
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
342a04e4063e288ea37e19615de7925836bc3f0a Normal file
View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "dab17558_f1c7cd95",
"filename": "horizon_mellanox/aboutpanel/tests.py",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 12171
},
"writtenOn": "2016-05-16T12:33:49Z",
"side": 1,
"message": "do we need this test?\ndo it make sens to unit test to the about panel?",
"range": {
"startLine": 6,
"startChar": 1,
"endLine": 7,
"endChar": 35
},
"revId": "342a04e4063e288ea37e19615de7925836bc3f0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dab17558_d15a89f1",
"filename": "horizon_mellanox/aboutpanel/urls.py",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 12171
},
"writtenOn": "2016-05-16T12:33:49Z",
"side": 1,
"message": "please use () instead of \\\nso it should be \nfrom horizon_mellanox.aboutpanel.views (\n import IndexView)",
"range": {
"startLine": 20,
"startChar": 0,
"endLine": 21,
"endChar": 20
},
"revId": "342a04e4063e288ea37e19615de7925836bc3f0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dab17558_9195a134",
"filename": "horizon_mellanox/aboutpanel/views.py",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 12171
},
"writtenOn": "2016-05-16T12:33:49Z",
"side": 1,
"message": "missing copyright",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 1,
"endChar": 25
},
"revId": "342a04e4063e288ea37e19615de7925836bc3f0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}