Update patch set 1

Patch Set 1: Code-Review-2

(13 comments)

this is a bad commit split it to several commits
ans don't put py files and swp file

Patch-set: 1
Reviewer: Gerrit User 12171 <12171@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-2
This commit is contained in:
Gerrit User 12171 2016-04-27 03:40:16 +00:00 committed by Gerrit Code Review
parent 58f745e850
commit 46cbb12aa3
2 changed files with 265 additions and 0 deletions

View File

@ -0,0 +1,215 @@
{
"comments": [
{
"key": {
"uuid": "1a122d0e_070faa39",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "please follow the guide lines of commit msg in openstack \nhttps://wiki.openstack.org/wiki/GitCommitMessages",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 56
},
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_0a068f1b",
"filename": "enabled/_7000_mlx.py",
"patchSetId": 1
},
"lineNbr": 23,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "why did you change package name to mellanox_dashbard?\nit show be horizon_mellanox like the name of the git",
"range": {
"startLine": 23,
"startChar": 23,
"endLine": 23,
"endChar": 40
},
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_4a140743",
"filename": "mellanox_dashboard/.models.py.swp",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "what is this ,swp file",
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_8a31ffef",
"filename": "mellanox_dashboard/__init__.pyc",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "remove pyc files",
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_6a2e238d",
"filename": "mellanox_dashboard/aboutpanel/.urls.py.swp",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "remove this",
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_ca4db773",
"filename": "mellanox_dashboard/aboutpanel/__init__.pyc",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "remove pyc",
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_aa52fb10",
"filename": "mellanox_dashboard/aboutpanel/panel.pyc",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "remove pyc",
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_0a54cffb",
"filename": "mellanox_dashboard/aboutpanel/panel.py~",
"patchSetId": 1
},
"lineNbr": 8,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "remove this file",
"range": {
"startLine": 1,
"startChar": 6,
"endLine": 8,
"endChar": 20
},
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_ea587333",
"filename": "mellanox_dashboard/aboutpanel/tests.py",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "what is this?",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 7,
"endChar": 35
},
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_4a42473f",
"filename": "mellanox_dashboard/aboutpanel/urls.pyc",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "remove pyc",
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_2a3f0bb5",
"filename": "mellanox_dashboard/aboutpanel/urls.py~",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 1,
"message": "remove this file",
"revId": "25de0ba200302ea4470a998f00f824201c86382e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}

View File

@ -0,0 +1,50 @@
{
"comments": [
{
"key": {
"uuid": "1a122d0e_470d223d",
"filename": "MANIFEST.in",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 0,
"message": "why did you remove this files",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 6,
"endChar": 19
},
"revId": "ac6fbb1a510ea538254eef0f78c0c4fda2b7fda5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_8703ba0f",
"filename": "babel.cfg",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 12171
},
"writtenOn": "2016-04-27T03:40:16Z",
"side": 0,
"message": "why delete this file",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 1,
"endChar": 15
},
"revId": "ac6fbb1a510ea538254eef0f78c0c4fda2b7fda5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}