Update patch set 3

Patch Set 3:

(4 comments)

can you please clarify on the Hard-Coded values.

Patch-set: 3
Reviewer: Gerrit User 27977 <27977@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 27977 2018-07-04 08:26:18 +00:00 committed by Gerrit Code Review
parent 3f01dae0a2
commit cff2eac479
1 changed files with 96 additions and 0 deletions

View File

@ -0,0 +1,96 @@
{
"comments": [
{
"key": {
"uuid": "5f7c97a3_0463dbb2",
"filename": "tools/salt_formulae/salt/create_endpoints.sls",
"patchSetId": 3
},
"lineNbr": 18,
"author": {
"id": 27977
},
"writtenOn": "2018-07-04T08:26:18Z",
"side": 1,
"message": "isn\u0027t this hardcoded??\n\nCan you please clarify.",
"range": {
"startLine": 18,
"startChar": 11,
"endLine": 18,
"endChar": 43
},
"revId": "714c781332676b83cdd7195ff5ded54a406775e5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_2467f7ba",
"filename": "tools/salt_formulae/salt/create_endpoints.sls",
"patchSetId": 3
},
"lineNbr": 24,
"author": {
"id": 27977
},
"writtenOn": "2018-07-04T08:26:18Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 24,
"startChar": 11,
"endLine": 24,
"endChar": 43
},
"revId": "714c781332676b83cdd7195ff5ded54a406775e5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_e4025fba",
"filename": "tools/salt_formulae/salt/create_endpoints.sls",
"patchSetId": 3
},
"lineNbr": 30,
"author": {
"id": 27977
},
"writtenOn": "2018-07-04T08:26:18Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 30,
"startChar": 11,
"endLine": 30,
"endChar": 43
},
"revId": "714c781332676b83cdd7195ff5ded54a406775e5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_04319ba2",
"filename": "tools/salt_formulae/salt/pillars_configuration.sh",
"patchSetId": 3
},
"lineNbr": 21,
"author": {
"id": 27977
},
"writtenOn": "2018-07-04T08:26:18Z",
"side": 1,
"message": "is not this hardcoded again.\nclarify this",
"range": {
"startLine": 21,
"startChar": 23,
"endLine": 21,
"endChar": 32
},
"revId": "714c781332676b83cdd7195ff5ded54a406775e5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}