x
/
nova-mksproxy
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

So it would be good to provide arguments for domain-name, not just ID.

Patch-set: 1
Label: Workflow=0
This commit is contained in:
Gerrit User 8119 2017-03-09 20:52:18 +00:00 committed by Gerrit Code Review
parent 0870ca55ac
commit bea63d7f96
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
2b63ff70a670415d81301073d4b289bc1bafaee3 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"key": {
"uuid": "9a30ddce_b2ce0f2c",
"filename": "novaproxy/mksproxy.py",
"patchSetId": 1
},
"lineNbr": 49,
"author": {
"id": 8119
},
"writtenOn": "2017-03-09T20:52:18Z",
"side": 1,
"message": "pylint would say this is not indented enough",
"range": {
"startLine": 49,
"startChar": 0,
"endLine": 49,
"endChar": 35
},
"revId": "2b63ff70a670415d81301073d4b289bc1bafaee3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a30ddce_f2d407be",
"filename": "novaproxy/mksproxy.py",
"patchSetId": 1
},
"lineNbr": 54,
"author": {
"id": 8119
},
"writtenOn": "2017-03-09T20:52:18Z",
"side": 1,
"message": "pylint would say this is not indented enough",
"range": {
"startLine": 54,
"startChar": 0,
"endLine": 54,
"endChar": 35
},
"revId": "2b63ff70a670415d81301073d4b289bc1bafaee3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}