x
/
omni
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(4 comments)

Patch-set: 4
Label: Code-Review=-1
This commit is contained in:
Gerrit User 25687 2019-02-25 10:39:01 +00:00 committed by Gerrit Code Review
parent 5145464b80
commit 3468fb1967
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
3799a3e05e115640aa0178ce21872bfa4b4978f7 Normal file
View File

@ -0,0 +1,72 @@
{
"comments": [
{
"key": {
"uuid": "9fdfeff1_e2fed803",
"filename": "devstack/lib/common_functions",
"patchSetId": 4
},
"lineNbr": 12,
"author": {
"id": 25687
},
"writtenOn": "2019-02-25T10:39:01Z",
"side": 1,
"message": "copy_omni_files",
"revId": "3799a3e05e115640aa0178ce21872bfa4b4978f7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_a2ee901e",
"filename": "devstack/lib/omni_aws",
"patchSetId": 4
},
"lineNbr": 32,
"author": {
"id": 25687
},
"writtenOn": "2019-02-25T10:39:01Z",
"side": 1,
"message": "setting AWS secret key, access key, region, zone seems common across all functions. Can we have a common function where we just pass conf file name ?\nLine 32-35",
"revId": "3799a3e05e115640aa0178ce21872bfa4b4978f7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_0252fc13",
"filename": "devstack/plugin.sh",
"patchSetId": 4
},
"lineNbr": 21,
"author": {
"id": 25687
},
"writtenOn": "2019-02-25T10:39:01Z",
"side": 1,
"message": "move line 21-23 in common functions only ?",
"revId": "3799a3e05e115640aa0178ce21872bfa4b4978f7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_02d75c4d",
"filename": "devstack/plugin.sh",
"patchSetId": 4
},
"lineNbr": 23,
"author": {
"id": 25687
},
"writtenOn": "2019-02-25T10:39:01Z",
"side": 1,
"message": "we are setting up credential manager service ? will that be a separate review?",
"revId": "3799a3e05e115640aa0178ce21872bfa4b4978f7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}