x
/
omni
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(3 comments)

Patch-set: 3
Label: Code-Review=-1
This commit is contained in:
Gerrit User 25687 2019-04-09 16:09:57 +00:00 committed by Gerrit Code Review
parent ea1cdcb1e9
commit 3a89f79681
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
adcfcf5584915bba61a8bd3eedb9e2370d653a88 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "5fc1f717_352cd897",
"filename": "devstack/lib/creds_mgr",
"patchSetId": 3
},
"lineNbr": 58,
"author": {
"id": 25687
},
"writtenOn": "2019-04-09T16:09:57Z",
"side": 1,
"message": "can we avoid sudo ? Create virtualenv as stack_user only ?",
"revId": "adcfcf5584915bba61a8bd3eedb9e2370d653a88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_fdff18ff",
"filename": "devstack/lib/creds_mgr",
"patchSetId": 3
},
"lineNbr": 64,
"author": {
"id": 25687
},
"writtenOn": "2019-04-09T16:09:57Z",
"side": 1,
"message": "why are we installing test requirements ?",
"revId": "adcfcf5584915bba61a8bd3eedb9e2370d653a88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_983ce1c8",
"filename": "neutron/neutron/plugins/ml2/drivers/aws/mechanism_aws.py",
"patchSetId": 3
},
"lineNbr": 216,
"author": {
"id": 25687
},
"writtenOn": "2019-04-09T16:09:57Z",
"side": 1,
"message": "we should require try except here . Just checking azmgr_url if we are able to get it or not.\nIf we need to handle exception it should be required for line 216 only",
"revId": "adcfcf5584915bba61a8bd3eedb9e2370d653a88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}