Update patch set 5

Patch Set 5: Code-Review-1 (5 comments) Patch-set: 5 Label: Code-Review=-1
2019-04-15 13:30:41 +00:00 · 2019-04-15 13:30:41 +00:00 · b395ee2952
parent e66edcaf9e
commit b395ee2952
1 changed files with 89 additions and 0 deletions
--- a/89
+++ b/89
@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3fce034c_93951ee7",
+        "filename": "neutron/neutron/plugins/ml2/drivers/aws/mechanism_aws.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 190,
+      "author": {
+        "id": 26097
+      },
+      "writtenOn": "2019-04-15T13:30:41Z",
+      "side": 1,
+      "message": "please follow pep8 rules",
+      "revId": "6ae78051a5f081b0c413f8863c400845aa7bf087",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_73bbd271",
+        "filename": "neutron/neutron/plugins/ml2/drivers/aws/mechanism_aws.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 222,
+      "author": {
+        "id": 26097
+      },
+      "writtenOn": "2019-04-15T13:30:41Z",
+      "side": 1,
+      "message": "this will fail if azmgr_url is \"\". i would suggest to call _validate_az only if we have got az from context",
+      "revId": "6ae78051a5f081b0c413f8863c400845aa7bf087",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_9363de1a",
+        "filename": "neutron/neutron/plugins/ml2/drivers/aws/mechanism_aws.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 227,
+      "author": {
+        "id": 26097
+      },
+      "writtenOn": "2019-04-15T13:30:41Z",
+      "side": 1,
+      "message": "follow pep8 rules",
+      "revId": "6ae78051a5f081b0c413f8863c400845aa7bf087",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_d3e406af",
+        "filename": "nova/virt/ec2/config.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 54,
+      "author": {
+        "id": 26097
+      },
+      "writtenOn": "2019-04-15T13:30:41Z",
+      "side": 1,
+      "message": "help\u003d\u0027keystone username\u0027\nsame for others",
+      "revId": "6ae78051a5f081b0c413f8863c400845aa7bf087",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3fce034c_f3dfc2d3",
+        "filename": "nova/virt/ec2/config.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 57,
+      "author": {
+        "id": 26097
+      },
+      "writtenOn": "2019-04-15T13:30:41Z",
+      "side": 1,
+      "message": "help\u003d\u0027keystone region name\u0027",
+      "revId": "6ae78051a5f081b0c413f8863c400845aa7bf087",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}