Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 8716 <8716@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 8716 2016-12-21 09:00:14 +00:00 committed by Gerrit Code Review
parent f39b05eb5f
commit e0bcded8d6
1 changed files with 18 additions and 0 deletions

View File

@ -105,6 +105,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_850ba923",
"filename": "specs/newton/approved/newton-instance-ha-host-monitoring-spec.rst",
"patchSetId": 2
},
"lineNbr": 205,
"author": {
"id": 8716
},
"writtenOn": "2016-12-21T09:00:14Z",
"side": 1,
"message": "How about have a general failure notification format for all the monitors as we do in masakari? The \"details\" could be differ from each monitor, however we have some common items such as \"event_type\", \"timestamp\", \"host/generated_host\"..etc.\n\nHere is an example of masakari notification API:\n \u0027type\u0027: {\n \u0027type\u0027: \u0027string\u0027,\n \u0027enum\u0027: fields.NotificationType.ALL,\n },\n \u0027hostname\u0027: parameter_types.hostname,\n \u0027generated_time\u0027: {\n \u0027type\u0027: \u0027string\u0027,\n \u0027format\u0027: \u0027date-time\u0027,\n },\n \u0027payload\u0027: parameter_types.payload,\n },\nIn here, payload equals to \"details\" in above e.g.\n\nAnd I would like to have some kind of id for each notification monitor sends. In masakari we use uuid. This has an impotent roll when we wants to identify the duplicate notifications.",
"parentUuid": "3a71b18c_1dce0282",
"revId": "3c17bc8997c36e09c5f0855165e073e01ad39385",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_31f9524e",