Update patch set 3
Patch Set 3: Code-Review+1 (2 comments) One of Dawid's points still needs addressing. Patch-set: 3 Label: Code-Review=+1
This commit is contained in:
parent
30ae4d2c24
commit
f5cee5bdd2
|
@ -0,0 +1,44 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ba5201f7_666dfd97",
|
||||
"filename": "specs/newton/approved/newton-instance-ha-vm-recovery-spec.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 2394
|
||||
},
|
||||
"writtenOn": "2017-01-04T02:18:03Z",
|
||||
"side": 1,
|
||||
"message": "As Dawid pointed out, this is not a recovery method and is outside the scope of this spec, so it should be deleted.",
|
||||
"revId": "a96f101677ae0379f20faf98f3a4902b3c502e08",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ba5201f7_a62b65ea",
|
||||
"filename": "specs/newton/approved/newton-instance-ha-vm-recovery-spec.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 77,
|
||||
"author": {
|
||||
"id": 2394
|
||||
},
|
||||
"writtenOn": "2017-01-04T02:18:03Z",
|
||||
"side": 1,
|
||||
"message": "Are these really alternatives? To me it sounds like they all satisfy the description of the proposed change above, i.e. they are valid ways of implementing the proposed change, not fundamentally different approaches to solving the problem. Maybe I am misunderstanding?",
|
||||
"range": {
|
||||
"startLine": 77,
|
||||
"startChar": 0,
|
||||
"endLine": 77,
|
||||
"endChar": 52
|
||||
},
|
||||
"revId": "a96f101677ae0379f20faf98f3a4902b3c502e08",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue