Update patch set 4

Browse Source

Patch Set 4: Code-Review+2

Thanks, this looks great!  

Am I right in assuming this is still purely a PoC and not yet tested?

There are a few minor details which could do with tweaking, but I'm not too worried about the polish right now.  I think it might be worth merging now just for the exposure.  It's not as if it would pollute a repository which is otherwise perfectly maintained 8-/

Andrew - I think the idea is that this plus masakari would replace the need for a large chunk of fence_{compute,evacuate}.  As per

https://aspiers.github.io/openstack-day-israel-2017-compute-ha/#/nova-host-alerter

the fence-agent would only need to write the flag in attrd. Masakari would take care of doing service-disable and all the evacuation.  The only bit I'm not sure of is what should call nova's force_down API.

Patch-set: 4
Label: Code-Review=+2

...

This commit is contained in:

Gerrit User 2394 2018-05-10 21:14:53 +00:00 committed by Gerrit Code Review

parent 31b10508c7

commit 564c49f129

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available