Update patch set 2
Patch Set 2: Code-Review-1 (3 comments) Thanks a lot! Looks great - happy to merge as soon as the minor nitpicks are addressed. Patch-set: 2 Label: Code-Review=-1
This commit is contained in:
parent
fc57ee19ed
commit
c1a0e0586c
|
@ -0,0 +1,73 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fa7e38b_a9ff2ea9",
|
||||
"filename": "ocf/NovaEvacuate",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 130,
|
||||
"author": {
|
||||
"id": 2394
|
||||
},
|
||||
"writtenOn": "2019-09-25T18:27:58Z",
|
||||
"side": 1,
|
||||
"message": "Let\u0027s reword to avoid making it sound like it\u0027s assuming there\u0027s always a storage array:\n\n\"Allows delaying the nova evacuate API call, e.g. to give a storage array ...\"",
|
||||
"range": {
|
||||
"startLine": 130,
|
||||
"startChar": 0,
|
||||
"endLine": 130,
|
||||
"endChar": 64
|
||||
},
|
||||
"revId": "964bfe7d09a75886947266d364acc4293a169f0b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fa7e38b_29257e5c",
|
||||
"filename": "ocf/NovaEvacuate",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 133,
|
||||
"author": {
|
||||
"id": 2394
|
||||
},
|
||||
"writtenOn": "2019-09-25T18:27:58Z",
|
||||
"side": 1,
|
||||
"message": "nit: lowercase slightly better IMHO, as this refers to either the CLI or the API.",
|
||||
"range": {
|
||||
"startLine": 133,
|
||||
"startChar": 21,
|
||||
"endLine": 133,
|
||||
"endChar": 34
|
||||
},
|
||||
"revId": "964bfe7d09a75886947266d364acc4293a169f0b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fa7e38b_a9188e1d",
|
||||
"filename": "ocf/NovaEvacuate",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 228,
|
||||
"author": {
|
||||
"id": 2394
|
||||
},
|
||||
"writtenOn": "2019-09-25T18:27:58Z",
|
||||
"side": 1,
|
||||
"message": "No tabs - please stay consistent with existing whitespace conventions.",
|
||||
"range": {
|
||||
"startLine": 228,
|
||||
"startChar": 0,
|
||||
"endLine": 228,
|
||||
"endChar": 3
|
||||
},
|
||||
"revId": "964bfe7d09a75886947266d364acc4293a169f0b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue