x
/
osops-tools-generic
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(3 comments)

So close!  Sorry dude..  see comments.

Patch-set: 6
Label: Code-Review=-1
This commit is contained in:
Gerrit User 9060 2015-12-16 22:23:03 +00:00 committed by Gerrit Code Review
parent 850244eab3
commit 21f1bab4e5
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
34df06a924f5a8e1d30868b0f09977fcb0c1bb83 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "3a7e1126_15db161d",
"filename": "nova/openstack_db_archive.sh",
"patchSetId": 6
},
"lineNbr": 88,
"author": {
"id": 9060
},
"writtenOn": "2015-12-16T22:23:03Z",
"side": 1,
"message": "instance_actions_events (missing \u0027s\u0027 after \u0027action\u0027)",
"revId": "34df06a924f5a8e1d30868b0f09977fcb0c1bb83",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_95af067d",
"filename": "nova/openstack_db_archive.sh",
"patchSetId": 6
},
"lineNbr": 94,
"author": {
"id": 9060
},
"writtenOn": "2015-12-16T22:23:03Z",
"side": 1,
"message": "missing ${NOSAI} after ${DRY_RUN}",
"revId": "34df06a924f5a8e1d30868b0f09977fcb0c1bb83",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_55cafe50",
"filename": "nova/openstack_db_archive.sh",
"patchSetId": 6
},
"lineNbr": 127,
"author": {
"id": 9060
},
"writtenOn": "2015-12-16T22:23:03Z",
"side": 1,
"message": "missing ${NOSAI} after ${DRY_RUN}",
"revId": "34df06a924f5a8e1d30868b0f09977fcb0c1bb83",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}