x
/
osops-tools-generic
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

I agree with Matt Fischer - I'd like to see nova-manage db archive_deleted_rows fixed, or at least have a current nova bug explaining why the nova-manage command is broken (and why would be nice).

I see two open bugs for the archive_deleted_rows command:

https://bugs.launchpad.net/nova/+bug/1183523

https://bugs.launchpad.net/nova/+bug/1305892

Also in looking at the code:

https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L6035

It seems odd that it doesn't make any attempt to sort the tables based on dependencies, like what I did here:

https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/migrate_repo/versions/267_instance_uuid_non_nullable.py#L73

Patch-set: 2
Reviewer: Gerrit User 6873 <6873@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 6873 2015-10-07 13:50:23 +00:00 committed by Gerrit Code Review
parent 1db1efd9ea
commit 282fa43a84
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available