x
/
osops-tools-generic
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(2 comments)

Looks like there are still some unintended changes on the db archive script.

Patch-set: 4
Label: Code-Review=-1
This commit is contained in:
Gerrit User 9060 2015-12-09 00:24:55 +00:00 committed by Gerrit Code Review
parent 596162a9fb
commit 3dbeb083e8
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
99594b48f63e04ab3d7636620aa0992e2312ec1f Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "7a740942_c1ae4d2d",
"filename": "nova/openstack_db_archive.sh",
"patchSetId": 4
},
"lineNbr": 29,
"author": {
"id": 9060
},
"writtenOn": "2015-12-09T00:24:55Z",
"side": 1,
"message": "I think this is another unintended change?",
"revId": "99594b48f63e04ab3d7636620aa0992e2312ec1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a740942_016f75fc",
"filename": "nova/openstack_db_archive.sh",
"patchSetId": 4
},
"lineNbr": 92,
"author": {
"id": 9060
},
"writtenOn": "2015-12-09T00:24:55Z",
"side": 1,
"message": "This area, too. These changes are probably fine, but should go in a different patch than this one for fixing bashate errors.",
"revId": "99594b48f63e04ab3d7636620aa0992e2312ec1f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}