x
/
osops-tools-generic
Code Issues Proposed changes

Review uuid verification method 

Previous method verify if line that contain "source file"
exists into dumpxml of every virtual machine to extract
uuid of virtual machines running on hypervisor but this
line exists only when a disk file is present on the host
and boot from volumes for example has not "source file" line
into dumpxml and this script will kill them.
To avoid theese case it should be possible to use
'virsh list --uuid --all' to list directly the virtual machine
uuids of nova instances.
This changes avoid to shut running customer virtual machines.

Change-Id: I27a70a526bc977b91a69ffe8d48955c63fd019b9
Closes-Bug: #1816434
Signed-off-by: Davide Panarese <dpanarese@enter.it>
This commit is contained in:
Davide Panarese 2019-02-18 15:34:23 +01:00
parent 7173543940
commit 44ed6cb375
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
libvirt/cleanup-orphaned-vms.sh
View File

@ -17,19 +17,17 @@ if [ -z "$UUIDS" ]; then
exit 1
fi
for uuid in `virsh list --uuid --all` ; do
echo $uuid | grep -E "$UUIDS" >/dev/null
for vm-uuid in `virsh list --uuid --all` ; do
echo $vm-uuid | grep -E "$UUIDS" >/dev/null
if [ $? -ne 0 ]; then
echo -n "+ $uuid is NOT known to OpenStack, removing managedsave info... "
[ -z "$1" ] && virsh managedsave-remove $uuid 1>/dev/null 2>&1
echo -n "+ $vm-uuid is NOT known to OpenStack, removing managedsave info... "
[ -z "$1" ] && virsh managedsave-remove $vm-uuid 1>/dev/null 2>&1
echo -n "destroying VM... "
[ -z "$1" ] && virsh destroy $uuid 1>/dev/null 2>&1
[ -z "$1" ] && virsh destroy $vm-uuid 1>/dev/null 2>&1
echo -n "undefining VM... "
[ -z "$1" ] && virsh undefine $uuid 1>/dev/null 2>&1
[ -z "$1" ] && virsh undefine $vm-uuid 1>/dev/null 2>&1
echo DONE
else
echo "* $uuid is known to OpenStack, not removing."
echo "* $vm-uuid is known to OpenStack, not removing."
fi
done