x
/
osops-tools-generic
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Cool beans, just a tiny review/changes.

Patch-set: 1
This commit is contained in:
Gerrit User 1297 2017-11-10 18:26:09 +00:00 committed by Gerrit Code Review
parent a95a91e6ad
commit 64f15a54f6
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee
View File

@ -1,5 +1,39 @@
{
"comments": [
{
"key": {
"uuid": "1f485f77_e35f330c",
"filename": "nova/vms_stats.py",
"patchSetId": 1
},
"lineNbr": 107,
"author": {
"id": 1297
},
"writtenOn": "2017-11-10T18:26:09Z",
"side": 1,
"message": "Just use __name__ ?",
"revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_63a903de",
"filename": "nova/vms_stats.py",
"patchSetId": 1
},
"lineNbr": 172,
"author": {
"id": 1297
},
"writtenOn": "2017-11-10T18:26:09Z",
"side": 1,
"message": "Doesn\u0027t just accessing self._VIRSH_VOLUME_CACHE work?",
"revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_836f5fc4",