Update patch set 2
Patch Set 2: (3 comments) Patch-set: 2
This commit is contained in:
parent
7efbca5ea6
commit
94e1b30adc
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_5e3fcc24",
|
||||
"filename": "nova/vms_stats.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 194,
|
||||
"author": {
|
||||
"id": 1297
|
||||
},
|
||||
"writtenOn": "2017-11-13T23:49:59Z",
|
||||
"side": 1,
|
||||
"message": "Please use `with contextlib.closing` to ensure this thing is always closed.\n\nhttps://docs.python.org/3/library/contextlib.html#contextlib.closing",
|
||||
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_feee78b2",
|
||||
"filename": "nova/vms_stats.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 209,
|
||||
"author": {
|
||||
"id": 1297
|
||||
},
|
||||
"writtenOn": "2017-11-13T23:49:59Z",
|
||||
"side": 1,
|
||||
"message": "Ok good, hopefully this isn\u0027t the default cause I\u0027m pretty sure we will start spinning up a bunch of virtual machines just to get this info (due to how guestfs works...)",
|
||||
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_1e4954cf",
|
||||
"filename": "nova/vms_stats.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 256,
|
||||
"author": {
|
||||
"id": 1297
|
||||
},
|
||||
"writtenOn": "2017-11-13T23:49:59Z",
|
||||
"side": 1,
|
||||
"message": "Does this connection need to be closed somewhere?",
|
||||
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue