x
/
osops-tools-generic
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(4 comments)

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 9545 2017-11-14 14:05:52 +00:00 committed by Gerrit Code Review
parent 484f8630bd
commit a20971ede2
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
9b24302da3de2c47e0d09303a62d69593aa521b0
View File

@ -34,6 +34,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_0b222653",
"filename": "nova/vms_stats.py",
"patchSetId": 2
},
"lineNbr": 209,
"author": {
"id": 9545
},
"writtenOn": "2017-11-14T14:05:52Z",
"side": 1,
"message": "\u003e Ok good, hopefully this isn\u0027t the default cause\n\nSetting all default values is moved to the separate method `set_config_defaults` for simplification searching default cases ;)",
"parentUuid": "1f485f77_feee78b2",
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_1e4954cf",
@ -51,6 +69,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_ab1672f0",
"filename": "nova/vms_stats.py",
"patchSetId": 2
},
"lineNbr": 256,
"author": {
"id": 9545
},
"writtenOn": "2017-11-14T14:05:52Z",
"side": 1,
"message": "fixed",
"parentUuid": "1f485f77_1e4954cf",
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_be7c80eb",
@ -68,6 +104,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_cbc9ae78",
"filename": "nova/vms_stats.py",
"patchSetId": 2
},
"lineNbr": 267,
"author": {
"id": 9545
},
"writtenOn": "2017-11-14T14:05:52Z",
"side": 1,
"message": "oh... I thought the list of vms is always constant over the host. jocking:)\n\nActually, good note, I forgot about this. Fixed",
"parentUuid": "1f485f77_be7c80eb",
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_de629c3e",
@ -84,6 +138,24 @@
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_aba792a7",
"filename": "nova/vms_stats.py",
"patchSetId": 2
},
"lineNbr": 328,
"author": {
"id": 9545
},
"writtenOn": "2017-11-14T14:05:52Z",
"side": 1,
"message": "\u003e What happens if the vm that this is attached to goes away?\n\nFixed. In the next patch-set the separate thread will take care about updating the list of vms to watch and the proper conditions in while-loop are used.\n\n\u003e Seeing as nova-compute will be destroying and making vms where this is running\n\nI suppose nova should not rely on readonly connection. At least while testing this script and possible raises, I was able to start/stop the VM.",
"parentUuid": "1f485f77_de629c3e",
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}