x
/
osops-tools-generic
Code Issues Proposed changes

Fix --noop condition 

[ ! -z "$1" ] execute code when an argument is defined. Remove ! into the condition to make --noop work properly

Signed-off-by: Davide Panarese <dpanarese@enter.it>

Change-Id: Ib9ec04a37bfe69e323f14f6bf4cb72b0fa818803
This commit is contained in:
Davide Panarese 2019-01-25 12:23:30 +01:00
parent 73953ddb5e
commit d15cc07690
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libvirt/cleanup-orphaned-vms.sh
View File

@ -22,11 +22,11 @@ for i in `virsh list --all | grep -E '^ [0-9-]+' | awk '{print $2;}'` ; do
virsh dumpxml $i | grep "source file" | grep -E "$UUIDS" >/dev/null
if [ $? -ne 0 ]; then
echo -n "+ $i is NOT known to OpenStack, removing managedsave info... "
[ ! -z "$1" ] && virsh managedsave-remove $i 1>/dev/null 2>&1
[ -z "$1" ] && virsh managedsave-remove $i 1>/dev/null 2>&1
echo -n "destroying VM... "
[ ! -z "$1" ] && virsh destroy $i 1>/dev/null 2>&1
[ -z "$1" ] && virsh destroy $i 1>/dev/null 2>&1
echo -n "undefining VM... "
[ ! -z "$1" ] && virsh undefine $i 1>/dev/null 2>&1
[ -z "$1" ] && virsh undefine $i 1>/dev/null 2>&1
echo DONE
else
echo "* $i is known to OpenStack, not removing."