From f8e2887068f00354a8fbae01b8fd28e75b22e59c Mon Sep 17 00:00:00 2001
From: Gerrit User 1297 <1297@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Mon, 13 Nov 2017 23:54:44 +0000
Subject: [PATCH] Update patch set 2

Patch Set 2:

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 1297 <1297@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
---
 9b24302da3de2c47e0d09303a62d69593aa521b0 | 34 ++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/9b24302da3de2c47e0d09303a62d69593aa521b0 b/9b24302da3de2c47e0d09303a62d69593aa521b0
index c905b7a..e21d05d 100644
--- a/9b24302da3de2c47e0d09303a62d69593aa521b0
+++ b/9b24302da3de2c47e0d09303a62d69593aa521b0
@@ -50,6 +50,40 @@
       "revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1f485f77_be7c80eb",
+        "filename": "nova/vms_stats.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 267,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2017-11-13T23:54:44Z",
+      "side": 1,
+      "message": "I would expect this list to change over time, so I\u0027m not sure listing the domains once will work. You probably need to do it in watch instead... so that this long-lived thing finds new vms.",
+      "revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1f485f77_de629c3e",
+        "filename": "nova/vms_stats.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 328,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2017-11-13T23:54:44Z",
+      "side": 1,
+      "message": "What happens if the vm that this is attached to goes away?\n\nSeeing as nova-compute will be destroying and making vms where this is running, we need to be careful about vms being removed under the covers (and we need to make sure nova is still allowed to remove them when we in here have a active libvirt connection to those vms).",
+      "revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }
\ No newline at end of file