Update patch set 1
Patch Set 1: (4 comments) Pretty cool! Have a few inline comments. Patch-set: 1 Reviewer: Gerrit User 10962 <10962@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
parent
96bd67f34b
commit
fd2332ee6e
|
@ -1,5 +1,22 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_e355f31e",
|
||||
"filename": "nova/vms_stats.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 93,
|
||||
"author": {
|
||||
"id": 10962
|
||||
},
|
||||
"writtenOn": "2017-11-10T20:14:56Z",
|
||||
"side": 1,
|
||||
"message": "Is this something that we anticipate that might run continuously on a HV?\n\nAny thought around network stats?\n\nI\u0027m wondering if this output could \"ultimately\" (but maybe not now) be pushed onto a queue for something to consume. Or maybe a output format that some other process could pick up and aggregate/publish?",
|
||||
"revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_e35f330c",
|
||||
|
@ -35,6 +52,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_23730bea",
|
||||
"filename": "nova/vms_stats.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 119,
|
||||
"author": {
|
||||
"id": 10962
|
||||
},
|
||||
"writtenOn": "2017-11-10T20:14:56Z",
|
||||
"side": 1,
|
||||
"message": "Units of time measure? (seconds, minutes, hours)?",
|
||||
"range": {
|
||||
"startLine": 115,
|
||||
"startChar": 3,
|
||||
"endLine": 119,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_23d9cb82",
|
||||
|
@ -135,6 +175,46 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_63390340",
|
||||
"filename": "nova/vms_stats.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 270,
|
||||
"author": {
|
||||
"id": 10962
|
||||
},
|
||||
"writtenOn": "2017-11-10T20:14:56Z",
|
||||
"side": 1,
|
||||
"message": "s/Find/Found",
|
||||
"range": {
|
||||
"startLine": 270,
|
||||
"startChar": 18,
|
||||
"endLine": 270,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_0307ef1e",
|
||||
"filename": "nova/vms_stats.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 401,
|
||||
"author": {
|
||||
"id": 10962
|
||||
},
|
||||
"writtenOn": "2017-11-10T20:14:56Z",
|
||||
"side": 1,
|
||||
"message": "So, from that I see there is a disk, memory, and cpu thread spawned for each VM. For a Hypervisor that contains say 50 VMs, we\u0027d be having 150 threads spawned/running?\nAlso, with launching the threads together, we could have times when all \"disk\" threads intervals expire together (and thus have a stampede effect). Wonder if there is a way to stagger the threads?",
|
||||
"revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f485f77_836f5fc4",
|
||||
|
|
Loading…
Reference in New Issue