osops-tools-generic/4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee

{
  "comments": [
    {
      "key": {
        "uuid": "1f485f77_e35f330c",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 107,
      "author": {
        "id": 1297
      },
      "writtenOn": "2017-11-10T18:26:09Z",
      "side": 1,
      "message": "Just use __name__ ?",
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_e38df37b",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 107,
      "author": {
        "id": 9545
      },
      "writtenOn": "2017-11-10T18:28:44Z",
      "side": 1,
      "message": "yup, it should work",
      "parentUuid": "1f485f77_e35f330c",
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_23d9cb82",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 161,
      "author": {
        "id": 9545
      },
      "writtenOn": "2017-11-10T18:29:40Z",
      "side": 1,
      "message": "should we get rid of this? (copy-paste to reduce external requirements)",
      "range": {
        "startLine": 159,
        "startChar": 20,
        "endLine": 161,
        "endChar": 72
      },
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_03c92f77",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 161,
      "author": {
        "id": 1297
      },
      "writtenOn": "2017-11-10T18:47:57Z",
      "side": 1,
      "message": "Sure, up to u.",
      "parentUuid": "1f485f77_23d9cb82",
      "range": {
        "startLine": 159,
        "startChar": 20,
        "endLine": 161,
        "endChar": 72
      },
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_63a903de",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 172,
      "author": {
        "id": 1297
      },
      "writtenOn": "2017-11-10T18:26:09Z",
      "side": 1,
      "message": "Doesn\u0027t just accessing self._VIRSH_VOLUME_CACHE work?",
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_c3e8b717",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 172,
      "author": {
        "id": 9545
      },
      "writtenOn": "2017-11-10T18:28:44Z",
      "side": 1,
      "message": "I do not remember why I decided to use class level variable at all. lol",
      "parentUuid": "1f485f77_63a903de",
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_23cc2b88",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 172,
      "author": {
        "id": 1297
      },
      "writtenOn": "2017-11-10T18:47:57Z",
      "side": 1,
      "message": ":-P",
      "parentUuid": "1f485f77_c3e8b717",
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_836f5fc4",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 417,
      "author": {
        "id": 9545
      },
      "writtenOn": "2017-11-10T18:19:58Z",
      "side": 1,
      "message": "oops, it accepts just a JSON.\n\nAlso, I suppose that we can switch to `key\u003dvalue` per line format to reduce external dependencies to just \"libvirt-python\"",
      "range": {
        "startLine": 417,
        "startChar": 69,
        "endLine": 417,
        "endChar": 77
      },
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "1f485f77_c3b797d8",
        "filename": "nova/vms_stats.py",
        "patchSetId": 1
      },
      "lineNbr": 417,
      "author": {
        "id": 1297
      },
      "writtenOn": "2017-11-10T18:57:24Z",
      "side": 1,
      "message": "works for me.",
      "parentUuid": "1f485f77_836f5fc4",
      "range": {
        "startLine": 417,
        "startChar": 69,
        "endLine": 417,
        "endChar": 77
      },
      "revId": "4cb3ddaa6dc8b373b03989f1ee97f1b75f6451ee",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}