89 lines
3.0 KiB
Plaintext
89 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "1f485f77_5e3fcc24",
|
|
"filename": "nova/vms_stats.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 194,
|
|
"author": {
|
|
"id": 1297
|
|
},
|
|
"writtenOn": "2017-11-13T23:49:59Z",
|
|
"side": 1,
|
|
"message": "Please use `with contextlib.closing` to ensure this thing is always closed.\n\nhttps://docs.python.org/3/library/contextlib.html#contextlib.closing",
|
|
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1f485f77_feee78b2",
|
|
"filename": "nova/vms_stats.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 209,
|
|
"author": {
|
|
"id": 1297
|
|
},
|
|
"writtenOn": "2017-11-13T23:49:59Z",
|
|
"side": 1,
|
|
"message": "Ok good, hopefully this isn\u0027t the default cause I\u0027m pretty sure we will start spinning up a bunch of virtual machines just to get this info (due to how guestfs works...)",
|
|
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1f485f77_1e4954cf",
|
|
"filename": "nova/vms_stats.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 256,
|
|
"author": {
|
|
"id": 1297
|
|
},
|
|
"writtenOn": "2017-11-13T23:49:59Z",
|
|
"side": 1,
|
|
"message": "Does this connection need to be closed somewhere?",
|
|
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1f485f77_be7c80eb",
|
|
"filename": "nova/vms_stats.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 267,
|
|
"author": {
|
|
"id": 1297
|
|
},
|
|
"writtenOn": "2017-11-13T23:54:44Z",
|
|
"side": 1,
|
|
"message": "I would expect this list to change over time, so I\u0027m not sure listing the domains once will work. You probably need to do it in watch instead... so that this long-lived thing finds new vms.",
|
|
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1f485f77_de629c3e",
|
|
"filename": "nova/vms_stats.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 328,
|
|
"author": {
|
|
"id": 1297
|
|
},
|
|
"writtenOn": "2017-11-13T23:54:44Z",
|
|
"side": 1,
|
|
"message": "What happens if the vm that this is attached to goes away?\n\nSeeing as nova-compute will be destroying and making vms where this is running, we need to be careful about vms being removed under the covers (and we need to make sure nova is still allowed to remove them when we in here have a active libvirt connection to those vms).",
|
|
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |