x
/
sqlalchemy-migrate
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review+1

hi i tested this locally with the following workflow and can confirm it fixes the problem

#create fedora29 docker container or use a fedora 29 host
sudo docker run --rm -it fedora bash
# recreate bug
yum install -y tox git python2-devel libffi-devel make gcc
cd ~
git clone http://github.com/openstack/nova
cd nova/
tox -e py27 -- test_create_fails_instance
#passes
dnf list --installed | grep sqlite
# shoudl be using 3.24
dnf install -y sqlite
tox -e py27 -- test_create_fails_instance
# fails

cd ~
git clone https://git.openstack.org/openstack/sqlalchemy-migrate
cd sqlalchemy-migrate/
git fetch https://git.openstack.org/openstack/sqlalchemy-migrate refs/changes/64/623564/7 && git checkout FETCH_HEAD
cd ~/nova/
.tox/py27/bin/pip install -e ~/sqlalchemy-migrate/
tox -e py27 -- test_create_fails_instance
#passes

Patch-set: 7
Label: Code-Review=+1
This commit is contained in:
Gerrit User 11604 2019-01-15 18:08:34 +00:00 committed by Gerrit Code Review
parent 3a066c418e
commit 065fb9ddc1
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available