x
/
swiftonfile
Code Issues Proposed changes

Remove keyword arguments from os.open call, instead add check for mode bits 

The open() method of OS module don't have any keyword arguments and would fail
with exceptions if **kwargs is passed.
Instead, I have added mode as named argument with 0o777 as default mode for
os.open() call

Change-Id: I5628883f4fb5ef7f08944673b0e5cc09bc166540
Signed-off-by: Varun Mittal <varun.mittal@in.ibm.com>
This commit is contained in:
Varun Mittal 2015-10-13 14:17:31 +05:30
parent 3083d14aff
commit 481d2226b1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
swiftonfile/swift/common/fs_utils.py
View File

@ -183,13 +183,13 @@ def do_fstat(fd):
return stats
def do_open(path, flags, **kwargs):
def do_open(path, flags, mode=0o777):
try:
fd = os.open(path, flags, **kwargs)
fd = os.open(path, flags, mode)
except OSError as err:
raise SwiftOnFileSystemOSError(
err.errno, '%s, os.open("%s", %x, %r)' % (
err.strerror, path, flags, kwargs))
err.errno, '%s, os.open("%s", %x, %o)' % (
err.strerror, path, flags, mode))
return fd