x
/
vmware-nsx
Code Issues Proposed changes

Don't fail when adding an existing nsx-security-group member 

Also don't fail if removing non-existing nsx-security-group member

Change-Id: I6ca7b1b96b00d76a28dc3a6983448b9a25c49653
(cherry picked from commit 464b90299a)
This commit is contained in:
Roey Chen 2015-07-22 00:54:15 -07:00 committed by Gary Kotton
parent e87249e23f
commit 783e43e7c8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
vmware_nsx/neutron/plugins/vmware/vshield/vcns.py
View File

@ -544,15 +544,15 @@ class Vcns(object):
def add_member_to_security_group(self, security_group_id, member_id):
"""Adds a vnic member to nsx security group."""
uri = '%s/%s/members/%s' % (SECURITYGROUP_PREFIX,
security_group_id, member_id)
uri = '%s/%s/members/%s?failIfExists=false' % (
SECURITYGROUP_PREFIX, security_group_id, member_id)
return self.do_request(HTTP_PUT, uri, format='xml', decode=False)
def remove_member_from_security_group(self, security_group_id,
member_id):
"""Removes a vnic member from nsx security group."""
uri = '%s/%s/members/%s' % (SECURITYGROUP_PREFIX,
security_group_id, member_id)
uri = '%s/%s/members/%s?failIfAbsent=false' % (
SECURITYGROUP_PREFIX, security_group_id, member_id)
return self.do_request(HTTP_DELETE, uri, format='xml', decode=False)
@retry_upon_exception(exceptions.RequestBad)