linters: standardise on newline at end of file

I noticed this by accident when I ran ansible-lint over this repo from
an outside context; it didn't use the .yamllint in here and started
compalining about eof whitespace.

After scratching my head for a bit as to why this didn't fail here, I
realised we've allowed various newlines since the initial commit
I936fe2c997597972d884c5fc62655d28e8aaf8c5.

Remove this and just use the default eof rules, and fixup the
whitespace as required.  This is fairly unimportant, but is nice for
consistency.

Change-Id: Idb46a1f39ba798b0bf70eaa27b4c6b4758ce3d26

.yamllint

@@ -10,9 +10,6 @@ rules:
     max-spaces-inside: 1
     level: error
   document-start: disable
-  empty-lines:
-    max: 1
-    max-end: 2
   indentation:
     level: error
     indent-sequences: consistent

playbooks/terraform/pre.yaml

@@ -2,4 +2,3 @@
   roles:
     - ensure-terraform
     - revoke-sudo
-

playbooks/terraform/run.yaml

@@ -1,4 +1,3 @@
 - hosts: all
   roles:
     - terraform
-

playbooks/tox-docs/pre.yaml

@@ -2,4 +2,3 @@
   roles:
     - role: bindep
       bindep_dir: "{{ zuul_work_dir }}"
-

roles/build-docker-image/tasks/setup-buildx.yaml

@@ -80,4 +80,3 @@
   file:
     state: absent
     path: '{{ etc_hosts_tmp.path }}'
-

roles/ensure-go/tasks/install-go.yaml

@@ -21,4 +21,3 @@
     dest: "{{ go_install_dir }}"
     remote_src: yes
   become: true
-

roles/ensure-packer/vars/main.yaml

@@ -4,4 +4,3 @@ packer_arch_translation:
   i386: 386
 
 packer_version_pattern: ^Packer v(?P<version>\d+\.\d+\.\d+).*$
-

roles/ensure-pip/tasks/workarounds.yaml

@@ -43,4 +43,3 @@
   when:
     - ansible_os_family == 'Debian'
     - _deb_venv_pkg.rc != 0
-

roles/ensure-terraform/tasks/main.yaml

@@ -9,4 +9,3 @@
     - terraform_installed_version.rc != 0 or
       "terraform_version != (terraform_installed_version.msg | \
        regex_replace(terraform_version_pattern, '\\g<version>'))"
-

roles/ensure-virtualenv/tasks/CentOS-7.yaml

@@ -3,4 +3,3 @@
     name:
       - python-virtualenv
   become: yes
-

roles/ensure-virtualenv/tasks/Gentoo.yaml

@@ -2,4 +2,3 @@
   package:
     name: dev-python/virtualenv
   become: yes
-

roles/golangci-lint/library/test-cases/single_line.yaml

@@ -25,4 +25,3 @@ comments:
   controllers/memcached_controller.go:
     - line: 130
       message: "S1039: unnecessary use of fmt.Sprintf (gosimple)"
-

roles/nimble/defaults/main.yaml

@@ -2,4 +2,3 @@ nimble_command: build
 nimble_use_siblings: true
 nimble_siblings: "{{ zuul.projects.values() | selectattr('required') | map(attribute='src_dir') | list }}"
 zuul_work_dir: "{{ zuul.project.src_dir }}"
-

roles/tox/library/test-cases/pep8_output.yaml

@@ -23,4 +23,3 @@ comments:
   tests/test_discovery.py:
     - line: 219
       message: E128 continuation line under-indented for visual indent
-

roles/tox/library/test-cases/pep8_output_envlist.yaml

@@ -24,4 +24,3 @@ comments:
   tests/test_discovery.py:
     - line: 219
       message: "pep8: E128 continuation line under-indented for visual indent"
-

roles/tox/library/test-cases/sphinx_output.yaml

@@ -21,4 +21,3 @@ comments:
   CONTRIBUTING.rst:
     - line: 96
       message: Unknown directive type "code-blockf".
-

roles/upload-afs-synchronize/tasks/main.yaml

@@ -16,4 +16,3 @@
     times: true
     recursive: true
     rsync_opts: '{{ ["--safe-links"] + ["--delete-after"] if not afs_copy_only else [] }}'
-

roles/validate-zone-db/defaults/main.yaml

@@ -1,3 +1,2 @@
 zone_files: '{{ ansible_user_dir }}/{{ zuul.project.src_dir }}'
 zone_db_files: []
-

test-playbooks/dstat-graph.yaml

@@ -19,4 +19,3 @@
     - role: dstat-graph
       vars:
         dstat_graph_cache_ignore: true
-

test-playbooks/ensure-docker.yaml

@@ -16,4 +16,3 @@
     - name: Validate docker default bridge networking containers have internet access
       command: |
         docker run --rm curlimages/curl:latest --no-progress-meter https://httpbin.org/get
-

test-playbooks/ensure-pip.yaml

@@ -70,4 +70,3 @@
 #     - role: ensure-pip
 #       vars:
 #         ensure_pip_from_upstream: True
-

test-playbooks/ensure-tox.yaml

@@ -53,4 +53,3 @@
       assert:
         that:
           - tox_executable == '{{ ansible_user_dir }}/tox-venv/bin/tox'
-