zuul
/
zuul
Code Issues Proposed changes
zuul/tests/fixtures
History
Tobias Henkel 01740bd147 Case sensitive label matching 
After upgrading Gerrit to 2.13 our gate stopped working. The reason
for this is that after a successful gate run zuul does something like
'gerrit review --label verified=2 --submit'. The verified label in
Gerrit by default is configured as 'Verified'. The newer version of
gerrit behaves different now. It accepts the +2 vote on verified but
doesn't submit the patch anymore if the casing is not correct. This
forces us to specify the label in the same casing as gerrit
expects. In that case the tolower() in canMerge prevents the patch
from entering the gate.

In order to avoid confusion and be consistent, avoid any case
conversions and use the labels exactly as defined in Gerrit.

Note that this patch requires changes to the pipelines such that the
labels are spelled exactly as defined in Gerrit.

This is a backport of I9713a075e07b268e4f2620c0862c128158283c7c to
master.

Change-Id: I55e6f12969c1c920a5017382523e71e12bc7ac3c
 		2017-09-15 14:38:44 -07:00
..
gerrit Support pagination in simplequery for Gerrit >=2.9 2015-08-31 11:42:15 +02:00
layouts Add support for 'connection' concept 2015-12-06 14:48:32 +11:00
clonemap.yaml cloner to easily clone dependent repositories 2014-07-29 09:03:59 +00:00
custom_functions.py Custom parameter function takes QueueItem 2013-07-11 21:53:17 +00:00
custom_functions_live_reconfiguration_functions.py Test that custom functions are live-reloaded 2013-08-13 10:03:41 -07:00
layout-abort-attempts.yaml Add attempts logic for jobs 2016-11-11 18:25:28 -05:00
layout-bad-queue.yaml Add queue-name parameter to job 2014-03-20 10:26:07 -07:00
layout-cloner.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-connections-multiple-gerrits.yaml Add in extra connections tests 2015-12-06 14:48:32 +11:00
layout-connections-multiple-voters.yaml Add in extra connections tests 2015-12-06 14:48:32 +11:00
layout-delayed-repo-init.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-disable-at.yaml Add support for disabling bad pipelines 2015-04-09 20:16:15 +10:00
layout-dont-ignore-deletes.yaml Add option to ignore ref-updated events emitted by branch deletions 2015-11-14 12:29:38 -05:00
layout-footer-message.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-idle.yaml Fix races in timer trigger tests. 2014-04-23 12:43:17 -07:00
layout-ignore-dependencies.yaml Add ignore-dependencies option 2015-02-09 15:20:34 -08:00
layout-live-reconfiguration-add-job.yaml Handle adding a job to a failing change during reconfig 2015-07-17 18:06:50 -07:00
layout-live-reconfiguration-del-project.yaml Dependencies from undefined projects 2015-09-24 15:46:37 +00:00
layout-live-reconfiguration-failed-job.yaml Fix bug with removing a failed job 2015-07-30 18:07:33 -07:00
layout-live-reconfiguration-functions.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-live-reconfiguration-shared-queue.yaml Fix bug with shared jobs in reconfiguration 2015-08-05 15:18:54 -07:00
layout-merge-failure.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-merge-queues.yaml Fix merging transitively-connected change queues. 2013-12-03 17:15:17 -08:00
layout-mutex-reconfiguration.yaml Fix missing mutex release when aborting builds 2016-11-18 09:15:36 +00:00
layout-mutex.yaml Add job mutex support 2016-02-04 16:51:58 -08:00
layout-no-jobs.yaml Add internal noop job 2014-03-18 10:56:47 -07:00
layout-no-timer.yaml Fix timer jobs getting aborted from abandoning a change 2015-04-03 15:01:38 -07:00
layout-rate-limit.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-repo-deleted.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-requirement-current-patchset.yaml Cleanup approval requirement testing 2014-06-24 09:38:31 -07:00
layout-requirement-email.yaml Revert "Add support for negative requirements" 2015-07-30 11:56:47 -07:00
layout-requirement-newer-than.yaml Revert "Add support for negative requirements" 2015-07-30 11:56:47 -07:00
layout-requirement-older-than.yaml Revert "Add support for negative requirements" 2015-07-30 11:56:47 -07:00
layout-requirement-open.yaml Cleanup approval requirement testing 2014-06-24 09:38:31 -07:00
layout-requirement-reject-username.yaml Add support to reject changes from approvals 2015-12-06 14:48:26 +11:00
layout-requirement-reject.yaml Add support to reject changes from approvals 2015-12-06 14:48:26 +11:00
layout-requirement-status.yaml Cleanup approval requirement testing 2014-06-24 09:38:31 -07:00
layout-requirement-username.yaml Make pipeline approval username requirement a regular expression 2016-06-16 09:46:49 -07:00
layout-requirement-vote.yaml Revert "Add support for negative requirements" 2015-07-30 11:56:47 -07:00
layout-requirement-vote1.yaml Revert "Add support for negative requirements" 2015-07-30 11:56:47 -07:00
layout-requirement-vote2.yaml Revert "Add support for negative requirements" 2015-07-30 11:56:47 -07:00
layout-skip-if.yaml Add support for a skip-if filter on jobs 2015-02-10 00:42:51 +00:00
layout-smtp.yaml Add support for emailing results via SMTP 2013-09-02 09:55:49 +10:00
layout-sql-reporter.yaml Add support for sqlalchemy reporter 2017-02-06 12:47:29 -05:00
layout-success-pattern.yaml Add extra test for bad url patterns 2016-04-23 10:40:12 +10:00
layout-swift.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-tags.yaml Add job tags 2016-03-09 10:07:28 -08:00
layout-timer-smtp.yaml Fix races in timer trigger tests. 2014-04-23 12:43:17 -07:00
layout-timer.yaml Fix races in timer trigger tests. 2014-04-23 12:43:17 -07:00
layout-zuultrigger-enqueued.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout-zuultrigger-merged.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
layout.yaml Case sensitive label matching 2017-09-15 14:38:44 -07:00
tags_custom_functions.py Add job tags 2016-03-09 10:07:28 -08:00
zuul-connections-bad-sql.conf Add support for sqlalchemy reporter 2017-02-06 12:47:29 -05:00
zuul-connections-multiple-gerrits.conf Add in extra connections tests 2015-12-06 14:48:32 +11:00
zuul-connections-same-gerrit.conf Merge "Add support for sqlalchemy reporter" 2017-02-16 00:42:21 +00:00
zuul.conf Fix setting of GIT_SSH for timer merge jobs 2017-02-08 18:19:58 +00:00