openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(3 comments)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 27615 \u003c27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34859\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34859 \u003c34859@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34859\u003e replied on the change"}
This commit is contained in:
Gerrit User 34859 2022-12-22 19:19:57 +00:00 committed by Gerrit Code Review
parent c6ea1ae51c
commit 5c766014f7
2 changed files with 65 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
5699cc6df51aecb93de50e9f3d15fac4889af896
View File

@ -16,6 +16,23 @@
"message": "Thanks for updating the spec. there is still one concern which is a major one. I was under the assumption that nova calls the new os-extend_volume_completion event and I believe that should be the behavior. see my comment inline.",
"revId": "5699cc6df51aecb93de50e9f3d15fac4889af896",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9bda3db7_4fa064b1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 34859
},
"writtenOn": "2022-12-22T19:19:57Z",
"side": 1,
"message": "Sorry for the late reply, I had to go afk for a few hours.",
"revId": "5699cc6df51aecb93de50e9f3d15fac4889af896",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

48
a354d3643190f7f94e2d040efc4476d7b82c4c05
View File

@ -230,6 +230,30 @@
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2a579f98_51ab7bbc",
"filename": "specs/2023.1/extend-volume-completion-action.rst",
"patchSetId": 8
},
"lineNbr": 69,
"author": {
"id": 34859
},
"writtenOn": "2022-12-22T19:19:57Z",
"side": 1,
"message": "I will try to find this out until tomorrow.",
"parentUuid": "1b0c5678_66298633",
"range": {
"startLine": 69,
"startChar": 0,
"endLine": 69,
"endChar": 39
},
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -490,6 +514,30 @@
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "222813ac_f21d86ff",
"filename": "specs/2023.1/extend-volume-completion-action.rst",
"patchSetId": 8
},
"lineNbr": 182,
"author": {
"id": 34859
},
"writtenOn": "2022-12-22T19:19:57Z",
"side": 1,
"message": "Of course Nova calls the os-extend_volume_completion action, as described in the \"Nova\" subsection!\n\nThe paragraph you are commenting on describes the \"VolumeManager.extend_volume()\" method using the \"VolumeManager.extend_volume_completion()\" method to rollback when it can\u0027t submit the event to Nova.\n\nWhat is missing in the spec is the following:\nIf no such error is encountered, then the event has been successfully submitted to Nova, and we can expect Nova to respond.\nThe \"VolumeManager.extend_volume()\" method will now return normally.\nThe Volume will be left in status \"extending\", until Nova eventually responds with the os-extend_volume_completion action.\n\nThis part of the behavior was left out because it felt obvious to me, which it isn\u0027t, of course. \nSorry about that!\nI will update this subsection to make this explicit.",
"parentUuid": "4163bd38_c5c08dbc",
"range": {
"startLine": 179,
"startChar": 63,
"endLine": 182,
"endChar": 17
},
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {