Update patch set 9
Patch Set 9: Code-Review-1
(8 comments)
Patch-set: 9
Reviewer: Gerrit User 27615 <27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 5cdf9a1c6e345dc5eb6bcb00c0e920e085b2ba8d
Attention: {"person_ident":"Gerrit User 27615 \u003c27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_27615\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34859 \u003c34859@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_27615\u003e replied on the change"}
This commit is contained in:
Gerrit User 27615
Gerrit Code Review
parent
6cff1a5153
commit
c6ea1ae51c
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "72c9c7b1_fc6c9b46",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 9
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for updating the spec. there is still one concern which is a major one. I was under the assumption that nova calls the new os-extend_volume_completion event and I believe that should be the behavior. see my comment inline.",
|
||||
"revId": "5699cc6df51aecb93de50e9f3d15fac4889af896",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -111,6 +111,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e7fd750d_cc66a711",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 66,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "Nova side should be good. we just want to log it at at least one place so operators will get to know why the operation failed.",
|
||||
"parentUuid": "595ad036_fc0e786e",
|
||||
"range": {
|
||||
"startLine": 66,
|
||||
"startChar": 36,
|
||||
"endLine": 66,
|
||||
"endChar": 41
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -182,6 +206,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "1b0c5678_66298633",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 69,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "This should be good but my question still stands,\n\n\"Does nova has enough priviledges in the operation to call an admin API? I know we do it in migrate volume but it\u0027s a admin only operation\"",
|
||||
"parentUuid": "ae968667_7e9dd72f",
|
||||
"range": {
|
||||
"startLine": 69,
|
||||
"startChar": 0,
|
||||
"endLine": 69,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -229,6 +277,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e8a8c3c1_dd138c33",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 111,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "That answers all my questions thanks.",
|
||||
"parentUuid": "d9a9968b_23e43ab3",
|
||||
"range": {
|
||||
"startLine": 110,
|
||||
"startChar": 2,
|
||||
"endLine": 111,
|
||||
"endChar": 66
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -394,6 +466,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4163bd38_c5c08dbc",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 182,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027m even more confused now. if cinder is going to call the `extend_volume_completion`, why do we need a new microversion and a new `os-extend_volume_completion` volume action?\nIt only makes sense if nova calls it.\nAlso we don\u0027t know when nova will complete the extend or if it will complete it successfully or not after it accepts the event. If nova fails and we extend the size here, it doesn\u0027t look like a good case.\nIMO nova should be the one calling this new volume action via REST API like we do for migrate volume completion",
|
||||
"parentUuid": "2db34200_215c3b7b",
|
||||
"range": {
|
||||
"startLine": 179,
|
||||
"startChar": 63,
|
||||
"endLine": 182,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -465,6 +561,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "4fa00b89_7fd2ccde",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 191,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "sounds reasonable.",
|
||||
"parentUuid": "006c4812_9cfb22ed",
|
||||
"range": {
|
||||
"startLine": 190,
|
||||
"startChar": 8,
|
||||
"endLine": 191,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -536,6 +656,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "cbe24618_26c3a0da",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 235,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "I understand the reason to remove extend_reservations but even keeping extend_new_size might confuse operators as to why it suddenly exists in their volume and keeping it doesn\u0027t do us any benefit.\nMarking as resolved as this is changed.",
|
||||
"parentUuid": "576a9279_b7638b7b",
|
||||
"range": {
|
||||
"startLine": 235,
|
||||
"startChar": 26,
|
||||
"endLine": 235,
|
||||
"endChar": 49
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -559,6 +703,30 @@
|
|||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "192b070d_52185557",
|
||||
"filename": "specs/2023.1/extend-volume-completion-action.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 301,
|
||||
"author": {
|
||||
"id": 27615
|
||||
},
|
||||
"writtenOn": "2022-12-22T15:55:50Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "fe88b8cc_fe005b34",
|
||||
"range": {
|
||||
"startLine": 300,
|
||||
"startChar": 2,
|
||||
"endLine": 301,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "a354d3643190f7f94e2d040efc4476d7b82c4c05",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue