openstack
/
cinder-specs
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(6 comments)

Patch-set: 6
Reviewer: Gerrit User 27615 <27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 8316027c4d924fb68dfe009264ab33c1698b01d1
Attention: {"person_ident":"Gerrit User 27615 \u003c27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_27615\u003e replied on the change"}
This commit is contained in:
Gerrit User 27615 2023-06-20 20:26:09 +00:00 committed by Gerrit Code Review
parent ab2e79687e
commit df84733657
1 changed files with 132 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

132
96adb1c5d940aa84a5dfc566e26e3cb2e73a1013
View File

@ -34,6 +34,138 @@
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a7d4919e_1714c9a4",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 27615
},
"writtenOn": "2023-06-20T20:26:09Z",
"side": 1,
"message": "this looks really good, few more comments inline",
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "52d042d0_790aec13",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 6
},
"lineNbr": 13,
"author": {
"id": 27615
},
"writtenOn": "2023-06-20T20:26:09Z",
"side": 1,
"message": "not exactly what i wanted here but should be good. if you do an update, we can leave it upto \"... attachment workflow.\"",
"range": {
"startLine": 13,
"startChar": 31,
"endLine": 13,
"endChar": 75
},
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ea368c95_397a6bcf",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 6
},
"lineNbr": 20,
"author": {
"id": 27615
},
"writtenOn": "2023-06-20T20:26:09Z",
"side": 1,
"message": "nit: can be enclosed in double back quotes (`) to highlight it",
"range": {
"startLine": 20,
"startChar": 7,
"endLine": 20,
"endChar": 13
},
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "983c2cf7_048adb9c",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 6
},
"lineNbr": 30,
"author": {
"id": 27615
},
"writtenOn": "2023-06-20T20:26:09Z",
"side": 1,
"message": "nit: redundant word",
"range": {
"startLine": 30,
"startChar": 2,
"endLine": 30,
"endChar": 9
},
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6bc55ceb_f787de7d",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 6
},
"lineNbr": 32,
"author": {
"id": 27615
},
"writtenOn": "2023-06-20T20:26:09Z",
"side": 1,
"message": "same",
"range": {
"startLine": 32,
"startChar": 66,
"endLine": 32,
"endChar": 67
},
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0863acb1_57008dae",
"filename": "specs/2023.2/dedicated-volume-backup-status-field.rst",
"patchSetId": 6
},
"lineNbr": 32,
"author": {
"id": 27615
},
"writtenOn": "2023-06-20T20:26:09Z",
"side": 1,
"message": "can we use double back quotes (`) instead of single ones, it highlights text in rst",
"range": {
"startLine": 32,
"startChar": 41,
"endLine": 32,
"endChar": 42
},
"revId": "96adb1c5d940aa84a5dfc566e26e3cb2e73a1013",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {