openstack
/
deb-neutron-fwaas
Code Issues Proposed changes

Refactor find iptables rules 

Using list comprehension instead of for loop, it's good for readability.

TrivialFix
Change-Id: Ieb003a615111738687a17c7d056a536c21c32f6e
This commit is contained in:
Dongcan Ye 2017-06-06 11:57:20 +08:00 committed by Dongcan Ye
parent daa852a463
commit b360565c49
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
neutron_fwaas/services/firewall/drivers/linux/iptables_fwaas.py
View File

@ -266,15 +266,11 @@ class IptablesFwaasDriver(fwaas_base.FwaasDriverBase):
return changed_rules
def _find_removed_rules(self, pre_firewall, firewall):
removed_rules = []
fw_rules_list = firewall[f_const.FIREWALL_RULE_LIST]
pre_fw_rules_list = pre_firewall[f_const.FIREWALL_RULE_LIST]
fw_rule_ids = []
for fw_rule in fw_rules_list:
fw_rule_ids.append(fw_rule.get('id'))
for pre_fw_rule in pre_fw_rules_list:
if pre_fw_rule.get('id') not in fw_rule_ids:
removed_rules.append(pre_fw_rule)
fw_rule_ids = [fw_rule.get('id') for fw_rule in fw_rules_list]
removed_rules = [pre_fw_rule for pre_fw_rule in
pre_fw_rules_list if pre_fw_rule.get('id') not in fw_rule_ids]
return removed_rules
def _find_new_rules(self, pre_firewall, firewall):