openstack
/
karbor
Code Issues Proposed changes

Add unit tests for trigger update API 

Change-Id: I7f74c0346eef45ac83207410756e003266989bba
This commit is contained in:
ericxiett 2018-02-11 14:03:18 +08:00 committed by Eric Xie
parent 95c1a0e7e2
commit 11ece54087
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
karbor/tests/unit/api/v1/test_triggers.py Normal file → Executable file
View File

@ -59,6 +59,14 @@ class TriggerApiTest(base.TestCase):
'start_time': datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S'),
},
}
self.default_update_trigger_param = {
"name": "123",
"properties": {
"format": "crontab",
"pattern": "* * * * *",
'start_time': datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S'),
},
}
def test_create_trigger_InvalidBody(self):
self.assertRaises(exception.ValidationError,
@ -113,6 +121,44 @@ class TriggerApiTest(base.TestCase):
self.req,
trigger['trigger_info']['id'])
def test_update_trigger_InvalidID(self):
param = self.default_update_trigger_param.copy()
body = self._get_create_trigger_request_body(param)
self.assertRaises(exc.HTTPBadRequest,
self.controller.update,
self.req, 'fake-id',
body=body)
def test_update_trigger_nonexist_trigger(self):
param = self.default_update_trigger_param.copy()
body = self._get_create_trigger_request_body(param)
self.assertRaises(exc.HTTPNotFound,
self.controller.update,
self.req, '42c8e647-cc13-4fc1-8d5b-b1e962290722',
body=body)
def test_update_trigger_InvalidName(self):
trigger = self._create_one_trigger()
param = self.default_update_trigger_param.copy()
param['name'] = 'a' * 256
body = self._get_create_trigger_request_body(param)
self.assertRaises(ValueError,
self.controller.update,
self.req, trigger['trigger_info']['id'],
body=body)
def test_update_trigger_miss_start_time(self):
trigger = self._create_one_trigger()
param = self.default_update_trigger_param.copy()
param['properties'].pop('start_time')
body = self._get_create_trigger_request_body(param)
self.assertRaises(exc.HTTPBadRequest,
self.controller.update,
self.req, trigger['trigger_info']['id'],
body=body)
def test_update_trigger(self):
trigger = self._create_one_trigger()