openstack
/
neutron-vpnaas
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
This commit is contained in:
Gerrit User 28619 2024-02-07 12:20:27 +00:00 committed by Gerrit Code Review
parent 9111045659
commit 7a9ac9b7fd
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
256464aea691f8b4957ba668a117963353f34e4c
View File

@ -34,6 +34,24 @@
"parentUuid": "edda46a8_8ab91d3e",
"revId": "256464aea691f8b4957ba668a117963353f34e4c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "21926aa9_b771418d",
"filename": "neutron_vpnaas/db/vpn/vpn_models.py",
"patchSetId": 2
},
"lineNbr": 108,
"author": {
"id": 28619
},
"writtenOn": "2024-02-07T12:20:27Z",
"side": 0,
"message": "Frankly speaking, I\u0027m not sure at all how to generate db migration here, as there\u0027s no alembic.ini withing the project defined, which I\u0027d expect to be present...\n\nI\u0027ve proposed patch to neutron-lib though: https://review.opendev.org/c/openstack/neutron-lib/+/908301",
"parentUuid": "d6792ada_cb0c10fc",
"revId": "256464aea691f8b4957ba668a117963353f34e4c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}