openstack
/
nova
Code Issues Proposed changes

remove unused parameter in rpc call 

The oslo.messaging rpc client call() method does not actually make
any use of a "timeout" parameter, so drop it from the call.  (It's
actually set up in the preceeding prepare() call.)

Change-Id: I662948cbb0c1fb89d8cb1e1ffad1909dc5b1dc68
This commit is contained in:
Chris Friesen 2017-03-17 10:30:24 -06:00
parent ae637e70a7
commit c6c68ba00b
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
nova/cells/rpcapi.py
View File

@ -328,8 +328,7 @@ class CellsAPI(object):
return cctxt.call(ctxt, 'proxy_rpc_to_manager', return cctxt.call(ctxt, 'proxy_rpc_to_manager',
topic=topic, topic=topic,
rpc_message=rpc_message, rpc_message=rpc_message,
call=call, call=call)
timeout=timeout)
def task_log_get_all(self, ctxt, task_name, period_beginning, def task_log_get_all(self, ctxt, task_name, period_beginning,
period_ending, host=None, state=None): period_ending, host=None, state=None):

5
nova/tests/unit/cells/test_cells_rpcapi.py
View File

@ -317,11 +317,10 @@ class CellsAPITestCase(test.NoDBTestCase):
call_info = self._stub_rpc_method('call', 'fake_response') call_info = self._stub_rpc_method('call', 'fake_response')
result = self.cells_rpcapi.proxy_rpc_to_manager( result = self.cells_rpcapi.proxy_rpc_to_manager(
self.fake_context, rpc_message='fake-msg', self.fake_context, rpc_message='fake-msg',
topic='fake-topic', call=True, timeout=-1) topic='fake-topic', call=True)
expected_args = {'rpc_message': 'fake-msg', expected_args = {'rpc_message': 'fake-msg',
'topic': 'fake-topic', 'topic': 'fake-topic',
'call': True, 'call': True}
'timeout': -1}
self._check_result(call_info, 'proxy_rpc_to_manager', self._check_result(call_info, 'proxy_rpc_to_manager',
expected_args, expected_args,
version='1.2') version='1.2')