ansible-linters fixes
https://review.openstack.org/#/c/485259/ is throwing linters problems related to this role. I think all of them are fixed with this patch Change-Id: If3924bb1b7823a9c70edf68d0127b9415885a2d9
This commit is contained in:
parent
27991691da
commit
c1f38edcea
|
@ -23,6 +23,7 @@ verbose: True
|
||||||
# Set the package install state for distribution packages
|
# Set the package install state for distribution packages
|
||||||
# Options are 'present' and 'latest'
|
# Options are 'present' and 'latest'
|
||||||
tacker_package_state: "latest"
|
tacker_package_state: "latest"
|
||||||
|
tacker_pip_package_state: "latest"
|
||||||
|
|
||||||
tacker_git_repo: https://git.openstack.org/openstack/tacker
|
tacker_git_repo: https://git.openstack.org/openstack/tacker
|
||||||
tacker_git_install_branch: master
|
tacker_git_install_branch: master
|
||||||
|
|
|
@ -30,7 +30,7 @@
|
||||||
- name: Check init system
|
- name: Check init system
|
||||||
command: cat /proc/1/comm
|
command: cat /proc/1/comm
|
||||||
register: _pid1_name
|
register: _pid1_name
|
||||||
changed_when: false
|
changed_when: False
|
||||||
tags:
|
tags:
|
||||||
- always
|
- always
|
||||||
|
|
||||||
|
|
|
@ -13,14 +13,13 @@
|
||||||
# See the License for the specific language governing permissions and
|
# See the License for the specific language governing permissions and
|
||||||
# limitations under the License.
|
# limitations under the License.
|
||||||
|
|
||||||
# TODO(mbuil): Fix the ansible lint
|
|
||||||
- name: Perform a tacker DB sync
|
- name: Perform a tacker DB sync
|
||||||
command: "{{ tacker_bin }}/tacker-db-manage
|
command: "{{ tacker_bin }}/tacker-db-manage
|
||||||
--config-file {{ tacker_etc_dir }}/tacker.conf upgrade head"
|
--config-file {{ tacker_etc_dir }}/tacker.conf upgrade head"
|
||||||
become: yes
|
become: yes
|
||||||
become_user: "{{ tacker_system_user_name }}"
|
become_user: "{{ tacker_system_user_name }}"
|
||||||
|
changed_when: False
|
||||||
tags:
|
tags:
|
||||||
- tacker-db-sync
|
- tacker-db-sync
|
||||||
- tacker-setup
|
- tacker-setup
|
||||||
- tacker-command-bin
|
- tacker-command-bin
|
||||||
- skip_ansible_lint
|
|
||||||
|
|
|
@ -26,14 +26,8 @@
|
||||||
notify:
|
notify:
|
||||||
- Restart tacker services
|
- Restart tacker services
|
||||||
|
|
||||||
# TODO(mbuil): Fix the ansible lint
|
|
||||||
# probably replace shell by command
|
|
||||||
- name: Reload init scripts
|
- name: Reload init scripts
|
||||||
shell: |
|
command: initctl reload-configuration
|
||||||
initctl reload-configuration
|
|
||||||
when: upstart_init | changed
|
when: upstart_init | changed
|
||||||
notify:
|
notify:
|
||||||
- Restart tacker services
|
- Restart tacker services
|
||||||
tags:
|
|
||||||
- skip_ansible_lint
|
|
||||||
|
|
||||||
|
|
|
@ -51,12 +51,10 @@
|
||||||
when:
|
when:
|
||||||
- not tacker_developer_mode | bool
|
- not tacker_developer_mode | bool
|
||||||
|
|
||||||
# TODO(mbuil): Fix the ansible lint
|
|
||||||
# Hint: latest should be a var.
|
|
||||||
- name: Install requires pip packages
|
- name: Install requires pip packages
|
||||||
pip:
|
pip:
|
||||||
name: "{{ tacker_requires_pip_packages | join(' ') }}"
|
name: "{{ tacker_requires_pip_packages | join(' ') }}"
|
||||||
state: latest
|
state: "{{ tacker_pip_package_state }}"
|
||||||
extra_args: "{{ pip_install_options_fact }}"
|
extra_args: "{{ pip_install_options_fact }}"
|
||||||
register: install_packages
|
register: install_packages
|
||||||
until: install_packages|success
|
until: install_packages|success
|
||||||
|
@ -115,12 +113,10 @@
|
||||||
notify:
|
notify:
|
||||||
- Restart tacker services
|
- Restart tacker services
|
||||||
|
|
||||||
# TODO(mbuil): Fix the ansible lint
|
|
||||||
# hint: latest should be a var.
|
|
||||||
- name: Install pip packages
|
- name: Install pip packages
|
||||||
pip:
|
pip:
|
||||||
name: "{{ tacker_pip_packages | join(' ') }}"
|
name: "{{ tacker_pip_packages | join(' ') }}"
|
||||||
state: latest
|
state: "{{ tacker_pip_package_state }}"
|
||||||
virtualenv: "{{ tacker_bin | dirname }}"
|
virtualenv: "{{ tacker_bin | dirname }}"
|
||||||
virtualenv_site_packages: "no"
|
virtualenv_site_packages: "no"
|
||||||
extra_args: "{{ pip_install_options_fact }}"
|
extra_args: "{{ pip_install_options_fact }}"
|
||||||
|
|
Loading…
Reference in New Issue