Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: Id2e037949562796d2608626ed8b1be7e004c099a

defaults/main.yml

@@ -16,9 +16,10 @@
 ## Verbosity Options
 debug: False
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 watcher_package_state: "latest"
+watcher_pip_package_state: "latest"
 
 ## Toggle developer mode
 watcher_developer_mode: false

tasks/main.yml

@@ -34,6 +34,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always

tasks/watcher_db_setup.yml

@@ -17,6 +17,7 @@
   command: "{{ watcher_bin }}/watcher-db-manage --config-file /etc/watcher/watcher.conf create_schema"
   become: yes
   become_user: "{{ watcher_system_user_name }}"
+  changed_when: false
   tags:
     - watcher-db-setup
     - watcher-setup

tasks/watcher_init_upstart.yml

@@ -25,8 +25,7 @@
     - Restart watcher services
 
 - name: Reload init scripts
-  shell: |
-    initctl reload-configuration
+  command: initctl reload-configuration
   when: upstart_init | changed
   notify:
     - Restart watcher services

tasks/watcher_install.yml

@@ -30,7 +30,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ watcher_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ watcher_pip_package_state }}"
     extra_args: >-
       {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
       {{ pip_install_options | default('') }}
@@ -106,7 +106,7 @@
 - name: Install pip packages
   pip:
     name: "{{ watcher_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ watcher_pip_package_state }}"
     virtualenv: "{{ watcher_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: >-