openstack
/
openstack-ansible-os_watcher
Code Issues Proposed changes

Fix linting issues for ansible-lint 3.4.1 

Preparing this role for the ansible-lint version bump

Change-Id: Id2e037949562796d2608626ed8b1be7e004c099a
This commit is contained in:
Jesse Pretorius 2016-11-09 21:48:57 +00:00
parent 0767a7b026
commit ba39fc1731
5 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
defaults/main.yml
View File

@ -16,9 +16,10 @@
## Verbosity Options ## Verbosity Options
debug: False debug: False
# Set the package install state for distribution packages # Set the package install state for distribution and pip packages
# Options are 'present' and 'latest' # Options are 'present' and 'latest'
watcher_package_state: "latest" watcher_package_state: "latest"
watcher_pip_package_state: "latest"
## Toggle developer mode ## Toggle developer mode
watcher_developer_mode: false watcher_developer_mode: false

1
tasks/main.yml
View File

@ -34,6 +34,7 @@
- name: Check init system - name: Check init system
command: cat /proc/1/comm command: cat /proc/1/comm
changed_when: false
register: _pid1_name register: _pid1_name
tags: tags:
- always - always

1
tasks/watcher_db_setup.yml
View File

@ -17,6 +17,7 @@
command: "{{ watcher_bin }}/watcher-db-manage --config-file /etc/watcher/watcher.conf create_schema" command: "{{ watcher_bin }}/watcher-db-manage --config-file /etc/watcher/watcher.conf create_schema"
become: yes become: yes
become_user: "{{ watcher_system_user_name }}" become_user: "{{ watcher_system_user_name }}"
changed_when: false
tags: tags:
- watcher-db-setup - watcher-db-setup
- watcher-setup - watcher-setup

3
tasks/watcher_init_upstart.yml
View File

@ -25,8 +25,7 @@
- Restart watcher services - Restart watcher services
- name: Reload init scripts - name: Reload init scripts
shell: | command: initctl reload-configuration
initctl reload-configuration
when: upstart_init | changed when: upstart_init | changed
notify: notify:
- Restart watcher services - Restart watcher services

4
tasks/watcher_install.yml
View File

@ -30,7 +30,7 @@
- name: Install requires pip packages - name: Install requires pip packages
pip: pip:
name: "{{ watcher_requires_pip_packages | join(' ') }}" name: "{{ watcher_requires_pip_packages | join(' ') }}"
state: latest state: "{{ watcher_pip_package_state }}"
extra_args: >- extra_args: >-
{{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }} {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
{{ pip_install_options | default('') }} {{ pip_install_options | default('') }}
@ -106,7 +106,7 @@
- name: Install pip packages - name: Install pip packages
pip: pip:
name: "{{ watcher_pip_packages | join(' ') }}" name: "{{ watcher_pip_packages | join(' ') }}"
state: latest state: "{{ watcher_pip_package_state }}"
virtualenv: "{{ watcher_bin | dirname }}" virtualenv: "{{ watcher_bin | dirname }}"
virtualenv_site_packages: "no" virtualenv_site_packages: "no"
extra_args: >- extra_args: >-