openstack
/
project-team-guide
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(3 comments)

Patch-set: 7
Reviewer: Gerrit User 8556 <8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 8dde754237fca5f7a3e1b8bad0634212830b97bd
Attention: {"person_ident":"Gerrit User 8556 \u003c8556@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8556\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 17685 \u003c17685@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8556\u003e replied on the change"}
This commit is contained in:
Gerrit User 8556 2024-01-19 21:00:12 +00:00 committed by Gerrit Code Review
parent b8c45a63eb
commit 4f658b26e1
1 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
0f755291340a7b8515df18974095d61dca2d7c82
View File

@ -51,6 +51,23 @@
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e895f05a_3251093f",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 8556
},
"writtenOn": "2024-01-19T21:00:12Z",
"side": 1,
"message": "Thanks Brian for update and taking care of it.\n\noverall looks good, agree wit Elod on last tag name change for unmaintained transition",
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -125,6 +142,30 @@
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d794f65e_d99ec51b",
"filename": "doc/source/stable-branches.rst",
"patchSetId": 7
},
"lineNbr": 155,
"author": {
"id": 8556
},
"writtenOn": "2024-01-19T21:00:12Z",
"side": 1,
"message": "yeah, I suggested the same to be used but you have good point that it can make the release team/tooling complex on the two type of this tag usage.\n\nI saw you used ``$series-eom`` @L113 as last tag before moving to unmaintained state so that should be enough. We can use ``$series-eom`` here in this paragraph too.",
"parentUuid": "f2cf1611_ad900a6c",
"range": {
"startLine": 151,
"startChar": 0,
"endLine": 155,
"endChar": 71
},
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -199,6 +240,24 @@
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b0d971f9_3a2e94da",
"filename": "doc/source/stable-branches.rst",
"patchSetId": 7
},
"lineNbr": 347,
"author": {
"id": 8556
},
"writtenOn": "2024-01-19T21:00:12Z",
"side": 1,
"message": "practically it is going to be Elod so we can write his name in bold here :P just kidding.",
"parentUuid": "d1559a55_5aff4d43",
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {