Add log_file parameter

Change-Id: Ice3b3565ef018a93aa7085beecf7b245b25e838b
Closes-Bug: #1819417
This commit is contained in:
ZhongShengping 2019-03-12 10:37:37 +08:00
parent 5c19836f20
commit 4bccd33974
3 changed files with 13 additions and 0 deletions

View File

@ -33,6 +33,10 @@
# If set to $::os_service_default, it will not log to any directory. # If set to $::os_service_default, it will not log to any directory.
# Defaults to $::designate::params::log_dir # Defaults to $::designate::params::log_dir
# #
# [*log_file*]
# (Optional) File where logs should be stored.
# Defaults to $::os_service_default
#
# [*logging_context_format_string*] # [*logging_context_format_string*]
# (Optional) Format string to use for log messages with context. # (Optional) Format string to use for log messages with context.
# Defaults to $::os_service_default # Defaults to $::os_service_default
@ -100,6 +104,7 @@ class designate::logging(
$use_stderr = $::os_service_default, $use_stderr = $::os_service_default,
$log_facility = $::os_service_default, $log_facility = $::os_service_default,
$log_dir = $::designate::params::log_dir, $log_dir = $::designate::params::log_dir,
$log_file = $::os_service_default,
$debug = $::os_service_default, $debug = $::os_service_default,
$logging_context_format_string = $::os_service_default, $logging_context_format_string = $::os_service_default,
$logging_default_format_string = $::os_service_default, $logging_default_format_string = $::os_service_default,
@ -123,6 +128,7 @@ class designate::logging(
use_journal => $use_journal, use_journal => $use_journal,
use_stderr => $use_stderr, use_stderr => $use_stderr,
log_dir => $log_dir, log_dir => $log_dir,
log_file => $log_file,
syslog_log_facility => $log_facility, syslog_log_facility => $log_facility,
logging_context_format_string => $logging_context_format_string, logging_context_format_string => $logging_context_format_string,
logging_default_format_string => $logging_default_format_string, logging_default_format_string => $logging_default_format_string,

View File

@ -0,0 +1,4 @@
---
features:
- |
Add the log_file option for logging.

View File

@ -29,6 +29,7 @@ describe 'designate::logging' do
:use_stderr => false, :use_stderr => false,
:log_facility => 'LOG_FOO', :log_facility => 'LOG_FOO',
:log_dir => '/var/log', :log_dir => '/var/log',
:log_file => '/var/log/designate/designate.log',
:debug => true, :debug => true,
} }
end end
@ -64,6 +65,7 @@ describe 'designate::logging' do
:use_stderr => '<SERVICE DEFAULT>', :use_stderr => '<SERVICE DEFAULT>',
:syslog_log_facility => '<SERVICE DEFAULT>', :syslog_log_facility => '<SERVICE DEFAULT>',
:log_dir => '/var/log/designate', :log_dir => '/var/log/designate',
:log_file => '<SERVICE DEFAULT>',
:debug => '<SERVICE DEFAULT>', :debug => '<SERVICE DEFAULT>',
) )
end end
@ -78,6 +80,7 @@ describe 'designate::logging' do
:use_stderr => false, :use_stderr => false,
:syslog_log_facility => 'LOG_FOO', :syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log', :log_dir => '/var/log',
:log_file => '/var/log/designate/designate.log',
:debug => true, :debug => true,
) )
end end